-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System tests: quadlet network test #16951
System tests: quadlet network test #16951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are copy-paste artifacts from the volume test left.
aba3f47
to
ff12959
Compare
@vrothberg Sorry for these. There're now fixed |
ff12959
to
633a1d4
Compare
@vrothberg following your last comment I realized that there was something wrong in the test itself. This lead me to find an issue in the Volume test (copy pasting erroneous code will produce erroneous code :) ). The fix to the Volume test is here: #16970. |
Signed-off-by: Ygal Blum <[email protected]>
633a1d4
to
9f0a37c
Compare
The fix to the code (#16971) was merged to main. This branch was rebased on top of the new main. So, it's ready to merge |
LGTM |
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this PR introduce a user-facing change?
No