Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tests: quadlet network test #16951

Merged

Conversation

ygalblum
Copy link
Contributor

Does this PR introduce a user-facing change?

No

None

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are copy-paste artifacts from the volume test left.

test/system/252-quadlet.bats Show resolved Hide resolved
test/system/252-quadlet.bats Outdated Show resolved Hide resolved
test/system/252-quadlet.bats Outdated Show resolved Hide resolved
@ygalblum ygalblum force-pushed the system-test-quadlet-network branch from aba3f47 to ff12959 Compare January 2, 2023 09:55
@ygalblum
Copy link
Contributor Author

ygalblum commented Jan 2, 2023

Looks like there are copy-paste artifacts from the volume test left.

@vrothberg Sorry for these. There're now fixed

@ygalblum ygalblum force-pushed the system-test-quadlet-network branch from ff12959 to 633a1d4 Compare January 2, 2023 12:58
@ygalblum
Copy link
Contributor Author

ygalblum commented Jan 2, 2023

@vrothberg following your last comment I realized that there was something wrong in the test itself. This lead me to find an issue in the Volume test (copy pasting erroneous code will produce erroneous code :) ). The fix to the Volume test is here: #16970.
Once both tests were fixed I found an issue in the handling of Network services in Quadlet. The fix is here: #16971.
So, while the test here is correct, it will only pass after #16971 is merged and this branch is rebased on it

@ygalblum ygalblum force-pushed the system-test-quadlet-network branch from 633a1d4 to 9f0a37c Compare January 3, 2023 15:26
@ygalblum
Copy link
Contributor Author

ygalblum commented Jan 3, 2023

The fix to the code (#16971) was merged to main. This branch was rebased on top of the new main. So, it's ready to merge

@rhatdan
Copy link
Member

rhatdan commented Jan 3, 2023

LGTM
@edsantiago @vrothberg PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM
but would like head nods from @edsantiago and @vrothberg

@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit f70233a into containers:main Jan 11, 2023
@ygalblum ygalblum deleted the system-test-quadlet-network branch January 12, 2023 08:16
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants