Output Size and Reclaimable in human form for json output #16904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@Luap99 PTAL |
|
@containers/podman-maintainers PTAL |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
reviewed
Jan 3, 2023
| @@ -145,6 +146,7 @@ func printSummary(cmd *cobra.Command, reports *entities.SystemDfReport) error { | |||
|
|
|||
| rpt := report.New(os.Stdout, cmd.Name()) | |||
| defer rpt.Flush() | |||
| report.DefaultFuncs["json"] = rptJSON | |||
There was a problem hiding this comment.
This looks like bad code style, we should not modify the global variable in a different package like that. It will work here because we exit after that but if we start adding another report template after that it will cause bugs.
I will create a PR with better fix
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh [email protected]
Fixes: #16902
Does this PR introduce a user-facing change?