Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman system df --format '{{json .}}' is not compliant with docker output #16902

Closed
benoitf opened this issue Dec 20, 2022 · 3 comments · Fixed by #16904
Closed

podman system df --format '{{json .}}' is not compliant with docker output #16902

benoitf opened this issue Dec 20, 2022 · 3 comments · Fixed by #16904
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. macos MacOS (OSX) related

Comments

@benoitf
Copy link
Contributor

benoitf commented Dec 20, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

I found an extension that parse the output of the JSON generated by system df command and the output is not rendered using the same format than docker command

Steps to reproduce the issue:

  1. podman system df --format '{{json .}}'

Describe the results you received:
{"Type":"Images","Total":5,"Active":1,"Size":1092221757,"Reclaimable":1092139196}

Describe the results you expected:
{"Active":"21","Reclaimable":"12.76GB (86%)","Size":"14.79GB","TotalCount":"73","Type":"Images"}

Reclaimable should have the size displayed with unit (like 12.76GB) and then it should have the percentage displayed
The same for the Size field.

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Client:       Podman Engine
Version:      4.3.1
API Version:  4.3.1
Go Version:   go1.19
Git Commit:   814b7b003cc630bf6ab188274706c383f9fb9915
Built:        Thu Nov 10 15:26:55 2022
OS/Arch:      darwin/amd64

Server:       Podman Engine
Version:      4.3.1
API Version:  4.3.1
Go Version:   go1.19.2
Built:        Fri Nov 11 16:01:27 2022
OS/Arch:      linux/amd64

Output of podman info:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman or brew info podman):

(paste your output here)

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide?

Yes/No

Additional environment details (AWS, VirtualBox, physical, etc.):

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 20, 2022
@github-actions github-actions bot added the macos MacOS (OSX) related label Dec 20, 2022
@benoitf benoitf changed the title podman system df --format '{{json .}}' is not compliant with docker system df --format '{{json .}}' output podman system df --format '{{json .}}' is not compliant with docker output Dec 20, 2022
@benoitf
Copy link
Contributor Author

benoitf commented Dec 22, 2022

It looks like it's missing the percentage in the output

@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2022

We must not be printing this out in regular podman system df commands, so open an issue on that, and we can add that output.

@benoitf
Copy link
Contributor Author

benoitf commented Dec 22, 2022

ok I will

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. macos MacOS (OSX) related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants