Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/system/250-systemd.bats: fix flake #16852

Closed
wants to merge 1 commit into from
Closed

test/system/250-systemd.bats: fix flake #16852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/system/250-systemd.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,14 @@ EOF

# Clean up
systemctl stop $service_name
run_podman 1 container exists $service_container
for i in {0..5}; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do a podman wait $service_container

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. Once #16853 is in, we can.

run_podman ? container exists $service_container
if [[ $status == 1 ]]; then
break
fi
sleep 0.5
done
is "$status" "1" "service container should have been removed"
run_podman 1 pod exists test_pod
run_podman rmi $(pause_image)
rm -f $UNIT_DIR/$unit_name
Expand Down