wait: add --ignore option #16853
Merged
wait: add --ignore option #16853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@edsantiago FYI - I think this can be a nice helper in the tests |
Luap99
reviewed
Dec 15, 2022
giuseppe
reviewed
Dec 16, 2022
In the recent past, I met the frequent need to wait for a container to exist that, at the same time, may get removed (e.g., system tests in [1]). Add an `--ignore` option to podman-wait which will ignore errors when a specified container is missing and mark its exit code as -1. Also remove ID fields from the WaitReport. It is actually not used by callers and removing it makes the code simpler and faster. Once merged, we can go over the tests and simplify them. [1] github.com/containers/pull/16852 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
wait-ignore
branch
from
5cd8ea6 to
f4d0496
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent past, I met the frequent need to wait for a container to exit that, at the same time, may get removed (e.g., system tests in [1]).
Add an
--ignoreoption to podman-wait which will ignore errors when a specified container is missing and mark its exit code as -1. Also remove ID fields from the WaitReport. It is actually not used by callers and removing it makes the code simpler and faster.Once merged, we can go over the tests and simplify them.
[1] github.com//pull/16852
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?
@containers/podman-maintainers PTAL