podman-remote,bindings: trim context path correctly when its emptydir
#16810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
flouthoc
force-pushed
the
trim-path-correctly
branch
from
3efdf66 to
4d99726
Compare
|
LGTM |
|
Still fighting with some tests on this one @flouthoc |
flouthoc
force-pushed
the
trim-path-correctly
branch
2 times, most recently
from
df69165 to
dfddda9
Compare
podman-remote converts and sends absolute path as context when its an emptydir by adding additional seperator however it should correctly trim the path and not add additional seperator for such use cases. Closes: BZ#2145054 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
trim-path-correctly
branch
from
dfddda9 to
553df87
Compare
|
@TomSweeneyRedHat Passes now. |
|
@containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 4, 2023
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jan 19, 2023
July 2022: test was flaking on new VM images. We needed new images, so I filed containers#15014 and skipped the test. January 2023: no attention from anyone, so I'll try bumping up a dd timeout from 10s to 30s. But in the interim, the test has broken: it used to expect "Containerfile" in output (this was deliberately added in containers#13655)... but containers#16810 changed that so Containerfile no longer appears. @flouthoc argues that this too is deliberate (containers#17059). Okay, so let's change the test then. All I care about is not adding more regressions. Signed-off-by: Ed Santiago <[email protected]>
This was referenced Jan 19, 2023
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman-remote converts and sends absolute path as context when its an emptydir by adding additional seperator however it should correctly trim the path and not add additional seperator for such use cases.
Closes: BZ#2145054