Prefer registering both machine and global pipe on Win #13655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1hility
changed the title
n1hility
force-pushed
the
dual-pipes
branch
4 times, most recently
from
f72a94d to
fde48ad
Compare
|
LGTM |
|
LGTM once tests go green |
|
@n1hility You have to rebase to fix the broken tests. |
Signed-off-by: Jason T. Greene <[email protected]>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jan 19, 2023
July 2022: test was flaking on new VM images. We needed new images, so I filed containers#15014 and skipped the test. January 2023: no attention from anyone, so I'll try bumping up a dd timeout from 10s to 30s. But in the interim, the test has broken: it used to expect "Containerfile" in output (this was deliberately added in containers#13655)... but containers#16810 changed that so Containerfile no longer appears. @flouthoc argues that this too is deliberate (containers#17059). Okay, so let's change the test then. All I care about is not adding more regressions. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13502
Also, makes dual registration behavior consistent with MacOS API Forwarding.
[NO NEW TESTS NEEDED]
Signed-off-by: Jason T. Greene [email protected]