-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus: Use released F37 CI VM images #16692
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1f4b40a
to
511a135
Compare
5defd5b
to
00ffce6
Compare
@adrianreber ping - I'm seeing this all over the place in our tests with CI VM Images built late last week:
This wasn't happening in my previous image update a week or so ago. Is there perhaps a broken package update that was released or did I screw something else up in the environment? |
could it be that the rpm is not part of the image? @cevich is |
I guess the crun RPM needs a Currently the crun RPM has a The best fix would be to change the crun spec file. The easy fix is to install criu-libs. |
@adrianreber should be both Recommends?
|
yes it seems to work fine with both dependencies, I'll fix that in the rpm |
I think criu is automatically pulled in by libs, so you can drop the non-libs dependency if you want. |
Thanks for taking a look guys. The CI VM builds scripts try not to spell out all the dependencies for exactly this reason: exposing dependency/requirement problems. Indeed, the build for these images only include criu and no libs. I'm glad a fix will make it's way into the rpm, can I assume that should land in Fedora within a month or so? Assuming so, it sounds like I need to rebuild images with a workaorund install of |
977f287
to
6e93f3f
Compare
@Luap99 you know about pasta, or am I confusing it with something else? Any idea why with a new-ish image update, I'm suddenly seeing these failures across all our rootless system tests? |
Signed-off-by: Chris Evich <[email protected]>
Installing things from a make file is almost never a good idea. Hard-coding paths to tools is also almost never a good idea. Nevertheless, this is now done as of c782795 and very difficult to undo. Further it renders mute, attempts to optimize by pre-installing tools during CI VM image production. Many attempts were made to correct this situation, all introduced further complexities and fragility. Abandon all hope and simply use the hard-coded paths unless/until somebody else has the mind to tackle this end-to-end. Ref: containers/automation_images#240 Signed-off-by: Chris Evich <[email protected]>
Ref: containers/automation_images#240 Signed-off-by: Chris Evich <[email protected]>
6e93f3f
to
98d57cf
Compare
Force-push: Rebased. |
closing in favor of #16525 |
Signed-off-by: Chris Evich [email protected]
Does this PR introduce a user-facing change?