Stop pre-installing podman utils/tools #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Combined with #238 |
|
#238 closed, re-opening this. |
Commit containers/podman@c782795 altered the way tooling is installed for podman making it incompatible with a c/automation_images pre-install. Several attempts were made to update podman's scripts and Makefile to de-hardcode this. All failed and/or were too complex. Instead, abandon the effort entirely, allowing podman to suffer any consequential runtime-install flakes or other bad behaviors. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
no_tools_install
branch
from
8c9c924 to
5287c4c
Compare
|
Note to me: Be sure to tag a new version after merging. |
Signed-off-by: Chris Evich <[email protected]>
|
Cirrus CI build successful. Found built image names and IDs:
|
cevich
added a commit
to cevich/podman
that referenced
this pull request
Jan 10, 2023
Installing things from a make file is almost never a good idea. Hard-coding paths to tools is also almost never a good idea. Nevertheless, this is now done as of c782795 and very difficult to undo. Further it renders mute, attempts to optimize by pre-installing tools during CI VM image production. Many attempts were made to correct this situation, all introduced further complexities and fragility. Abandon all hope and simply use the hard-coded paths unless/until somebody else has the mind to tackle this end-to-end. Ref: containers/automation_images#240 Signed-off-by: Chris Evich <[email protected]>
cevich
added a commit
to cevich/podman
that referenced
this pull request
Jan 10, 2023
Ref:
containers/automation_images#240
Signed-off-by: Chris Evich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
containers/podman@c782795 altered the way tooling is installed for podman making it incompatible with a c/automation_images pre-install. Several attempts were made to update podman's scripts and Makefile to de-hardcode this. All failed and/or were too complex. Instead, abandon the effort entirely, allowing podman to suffer any consequential runtime-install flakes or other bad behaviors.
Signed-off-by: Chris Evich [email protected]