Documenting Hyper-V QEMU acceleration settings #16609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n1hility a minor fix, you requested in #15851 (comment) |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arixmkii, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@arixmkii Can you rebase and force push. I added the [NO NEW TESTS NEEDED] flag. Then we can merge this PR. |
Signed-off-by: Arthur Sengileyev <[email protected]>
|
Rebased. |
|
Restarted one issue that I think is a flake? |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #15851 as it was merged before I managed to update it.
Also, I did some more investigation on mwait_idle kernel panic. It seems that some hardware goes with this flag disabled and it is known to cause issues for Hyper-V VMs (one case documented here (for Windows VMs though) https://portal.nutanix.com/page/documents/kbs/details?targetId=kA07V000000LV1aSAG).
I didn't manage to debug down if either Hyper-V, host or both wrongly detect MONITOR/MWAIT presence, but I think putting this to
monitor=offis also good for improved portability and wider host support.Signed-off-by: Arthur Sengileyev [email protected]
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]