Default qemu flags for Windows amd64 #15851
Conversation
|
Thanks @arixmkii. I added the [NO NEW TESTS NEEDED] flag, you will need to repush to get this to pass tests. |
arixmkii
force-pushed
the
win_qemu_settings
branch
from
e603a29 to
fbd6f46
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
Signed-off-by: Arthur Sengileyev <[email protected]>
arixmkii
force-pushed
the
win_qemu_settings
branch
from
fbd6f46 to
77f8eaa
Compare
|
Rebased to latest main after 4.3.0 release. |
| ) | ||
|
|
||
| func (v *MachineVM) addArchOptions() []string { | ||
| opts := []string{"-machine", "q35,accel=whpx:tcg", "-cpu", "max,vmx=off,monitor=off"} |
There was a problem hiding this comment.
minor nit: Could you add a comment here explaining like you did in the PR why certain flags have to be disabled and maybe a bug ref if you think its pertinent (e.g. https://gitlab.com/qemu-project/qemu/-/issues/628 for vmx=off)
There was a problem hiding this comment.
can be in a later PR if you prefer, not blocking to me
|
/approve LGTM |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arixmkii, n1hility, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Windows specific QEMU defaults are prominently missing from code as of now. This adds set of opts compatible with Hyper-V accelerator and selects Hyper-V as accelerator. This doesn't yet enable QEMU support on windows, so, no new test required for now.
-cpu hostis not available forwhpxaccel, so, to stay target agnostic it is needed to either usebaseand enable cpu options one by one, or go withmaxand disable ones, which cause problems.This PR sets cpu to
max,vmx=off,monitor=off. It was experimentally discovered in this experiment #13006vmx=offprevents QEMU from immediately crashing trying to initialize hypervizor;monitor=offprevents kernel panic during FCOS boot sequence.Tested with:
For Skylake I had to add
tsc=off. This was also needed if using target Skylake-Client (though it should be a match with the host). And even for SandyBridge target. So, I suspect that this to be an issue with CPU, BIOS, Logical Board combination and don't see that this should go into defaults. Also, Skylake CPUs are aged already considered legacy and even not capable to work with Win11 and should not dictate the defaults for future version of SW (personal opinion here).[NO NEW TESTS NEEDED]
Signed-off-by: Arthur Sengileyev [email protected]
Does this PR introduce a user-facing change?