Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specgen: support CDI devices from containers.conf #16580

Merged
merged 2 commits into from
Nov 28, 2022
Merged

specgen: support CDI devices from containers.conf #16580

merged 2 commits into from
Nov 28, 2022

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Nov 21, 2022 •
edited
Loading

Closes: #16232

Signed-off-by: Giuseppe Scrivano [email protected]

Needs: containers/common#1239

It is now possible to specify CDI devices in the containers.conf file

@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2022
@giuseppe giuseppe mentioned this pull request Nov 21, 2022
Closed
@giuseppe giuseppe force-pushed the specgen-support-cdi-devices branch from e3d89db to 7b64007 Compare November 24, 2022 10:38
@giuseppe giuseppe marked this pull request as ready for review November 24, 2022 10:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
@giuseppe giuseppe force-pushed the specgen-support-cdi-devices branch from 7b64007 to 5d26628 Compare November 25, 2022 10:44
@giuseppe giuseppe added the bloat_approved Approve a PR in which binary file size grows by over 50k label Nov 25, 2022
@giuseppe
Copy link
Member Author

@containers/podman-maintainers PTAL

flouthoc
flouthoc approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Nov 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit ab7f609 into containers:main Nov 28, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDI spec devices are not valid input in all device input locations
4 participants
@giuseppe @rhatdan @flouthoc @openshift-merge-robot