Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate: ignore validation of CDI devices #1239

Merged
merged 2 commits into from
Nov 23, 2022
Merged

validate: ignore validation of CDI devices #1239

merged 2 commits into from
Nov 23, 2022

Conversation

giuseppe
Copy link
Member

Signed-off-by: Giuseppe Scrivano [email protected]

@giuseppe giuseppe mentioned this pull request Nov 21, 2022
Closed
@giuseppe giuseppe force-pushed the validate-cdi-devices branch from e13a8ec to 8576007 Compare November 21, 2022 21:21
rhatdan
rhatdan reviewed Nov 21, 2022
View reviewed changes
pkg/config/config_local.go Outdated
@@ -11,6 +11,7 @@ import (
"strings"
"syscall"

cdi "github.com/container-orchestrated-devices/container-device-interface/pkg/cdi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the cdi here necessary?

@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2022

Wonder why go.sum changed so much.

@giuseppe giuseppe force-pushed the validate-cdi-devices branch from 8576007 to dc40f9b Compare November 21, 2022 21:40
@giuseppe giuseppe mentioned this pull request Nov 21, 2022
Merged
@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2022

Pretty big jump in the number of lines to verify the device? Is all that needed?

@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2022

+3000 lines of code.

@vrothberg
Copy link
Member

Pretty big jump in the number of lines to verify the device? Is all that needed?

96597e9 adds the new dependency which seems to be using a K8s YAML parser.

@giuseppe
Copy link
Member Author

It is already a dependency of Podman. I think it should not affect the podman binary size

@giuseppe
Copy link
Member Author

we could also drop the validation and let Podman deal with it

@rhatdan rhatdan mentioned this pull request Nov 22, 2022
Closed
@rhatdan
Copy link
Member

rhatdan commented Nov 23, 2022

LGTM
@vrothberg @flouthoc PTAL

vrothberg
vrothberg reviewed Nov 23, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit e120413 into containers:main Nov 23, 2022
flouthoc
flouthoc approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg vrothberg mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg left review comments

@rhatdan rhatdan rhatdan left review comments

@flouthoc flouthoc flouthoc approved these changes

Assignees

@vrothberg vrothberg

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giuseppe @rhatdan @vrothberg @flouthoc @openshift-merge-robot