[CI:DOCS] New tool, docs/version-check #16478
Conversation
openshift-ci
bot
added
release-note-none
approved
| @@ -275,6 +275,7 @@ function _run_altbuild() { | |||
| *Windows*) | |||
| make podman-remote-release-windows_amd64.zip | |||
| make podman.msi | |||
There was a problem hiding this comment.
Huh. Should we replace this with building the new EXE installer? @n1hility
There was a problem hiding this comment.
I think #15610 is what does the EXE step, and if I read that correctly it can run only on Windows. This step here is a Linux one (the full name is "Windows Cross").
So maybe the question is, should we get rid of this step completely? Those Makefile steps are too convoluted for me to grok at a glance, but ISTR that they run a few doc checks that are important.
|
This is a belated followup to #13947. As of the moment I write this, the script will fail on run because the v4.3.1 EXE file does not exist. I assume that will be fixed later today or tomorrow? Anyhow, this step should run and pass on this PR submission because this will not run on PRs. It should then run and FAIL on the next nightly cron, but we won't know until the Github Workflow bug is fixed. Once the EXE is built and uploaded, and this PR is merged, I would be most grateful if someone would run it manually to see if the auto-doc-updating works and is user-friendly enough. |
|
Confirmed: it ran and passed |
Intended to be run from nightly Cirrus cron job. 1) Queries github for highest-sorting (not necessarily "latest") tag 2) Checks that the Windows MSI exists, fails if not 3) Cross-checks markdown files to ensure they have up-to-date links When run interactively, it will auto-update the .md files to show and link to the latest version. This makes it easy for anyone to then submit an update PR. And, it turns out that MSI is obsolete, the new thing is EXE. Update the tutorials to reflect that. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
docs_version_check
branch
from
2f01191 to
db439dd
Compare
|
v4.3.1 EXEs are now up; the script can now be tested in production. |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Would someone be so kind as to run this script to update the docs? $ git checkout -b update_windows_release_links_or_whatever_you_want_to_call_it
$ docs/version-check |
github-actions
bot
added
the
locked - please file new issue/PR
Intended to be run from nightly Cirrus cron job.
When run interactively, it will auto-update the .md files
to show and link to the latest version. This makes it easy
for anyone to then submit an update PR.
And, it turns out that MSI is obsolete, the new thing is EXE.
Update the tutorials to reflect that.
Signed-off-by: Ed Santiago [email protected]