-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect download link on podman.io for Windows #13947
Comments
Oh good, github for some reason always uses the date to check what the latest release is instead of semver. So all latest links are redirected to v3.4.7 currently. This is very bad since we use the latest link in several places. Even worse there is no way to manually overwrite the latest release in github, according to https://stackoverflow.com/questions/22822586/swap-latest-release-on-github you need to change your commit date on the tag which sounds like a bad idea to me. @mheon @containers/podman-maintainers PTAL |
Well damn. We can't actually alter tags once they're created because they are signed. Our only potential option would be to tag a new release from the latest release branch? |
I don't think this is the solution. It will happen again every time we have to do a release from an old branch. |
I'm fine with that, as it shifts the solution away from me and to other folks 😄 Given this - should we move the issue to the podman.io repo? |
No this also applies to podman, for example the link in our Readme also points to latest |
Naturally, because nothing can ever be simple. That can probably be done manually as part of the release process. Podman.io seems scriptable, though. |
Manually == it will be forgotten, as least that is my experience. |
Fair. I wonder if we could GH actions this - on new tag, check semantic version versus readme latest, update if newer? |
|
We should not use teh latest link for github releases. It will will always use the latest tag based on the date not semver. So this will point to v3.4.7 at the moment. Because such things can happen again we should manually set the version and update it for each release. Ideally we have some form of automation for this. see containers/podman#13947 Signed-off-by: Paul Holzinger <[email protected]>
We should not use the latest link for github releases. It will will always use the latest tag based on the date not semver. So this will point to v3.4.7 at the moment. Because such things can happen again we should manually set the version and update it for each release. Ideally we have some form of automation for this. see containers/podman#13947 Signed-off-by: Paul Holzinger <[email protected]>
We should not use the latest link for github releases. It will will always use the latest tag based on the date not semver. So this will point to v3.4.7 at the moment. Because such things can happen again we should manually set the version and update it for each release. Ideally we have some form of automation for this. see containers/podman#13947 Signed-off-by: Paul Holzinger <[email protected]>
The link is now fixed. We can carry on the conversation here on how to make this human proof. |
Hi! This has been on my backburner for months. I have a script intended to take care of this, and as of a few minutes ago I confirmed that it handles the v4.3.0 -> .1 transition. However: there is no "msi" for v4.3.0. How do msi files get created? Is that a manual process? Will there be one for v4.3.1? My script fails if it doesn't find the corresponding msi file. |
I think at the moment we've stopped providing msi's and have now moved to an .exe based installer |
I think we're still building MSI's though in our CI so I can upload the MSI regardless, that shouldn't be an issue if we want to continue providing MSI's |
Oh I don't care! I've never used Windows and am unlikely ever to. I just want our documentation and links to be accurate. |
The windows install section on podman.io no longer directly links to the binaries, just to the tutorial which links to the the github release page so this is not really a problem any more. |
Uh, well, except that the tutorials say:
And one of them also says:
I find that offensive. It's very easy (in fact, it's done except for review and merge) to automate this, add a link of the form: As of YYYY-MM-DD the latest version is [vX.Y.Z](https://link/to/that/exe-or-msi-or-whatever) So: (1) should I fix the tutorials to say "exe" instead of "msi"? And (2) should I continue with this work? |
RE 1, definitely - the MSI is now legacy. RE 2, IMO we could just as easily point to the Github releases page and say grab the link from the latest release... But that's also not perfect (releases are chronological, so if we were to do a 3.4.8 right now it would show as latest until we cut 4.3.2), so I won't object to doing this the right way. |
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
When visiting https://podman.io/getting-started/installation#windows, the latest remote client link points to https://github.com/containers/podman/releases/latest/download/podman-remote-release-windows_amd64.zip
However, the latest releases in https://github.com/containers/podman/releases/ are CVEs that do not contain any windows release.
This means Windows users might be under the impression that you cannot install podman on Windows, since the link 404s.
Steps to reproduce the issue:
Visit https://podman.io/getting-started/installation#windows
Try downloading the "latest remote client"
Describe the results you received:
File not found
Describe the results you expected:
File is downloaded
The text was updated successfully, but these errors were encountered: