Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect download link on podman.io for Windows #13947

Closed
m-czernek opened this issue Apr 21, 2022 · 17 comments
Closed

Incorrect download link on podman.io for Windows #13947

m-czernek opened this issue Apr 21, 2022 · 17 comments
Labels
documentation Issue or fix is in project documentation kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@m-czernek
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

When visiting https://podman.io/getting-started/installation#windows, the latest remote client link points to https://github.com/containers/podman/releases/latest/download/podman-remote-release-windows_amd64.zip

However, the latest releases in https://github.com/containers/podman/releases/ are CVEs that do not contain any windows release.
This means Windows users might be under the impression that you cannot install podman on Windows, since the link 404s.

Steps to reproduce the issue:

  1. Visit https://podman.io/getting-started/installation#windows

  2. Try downloading the "latest remote client"

Describe the results you received:

File not found

Describe the results you expected:

File is downloaded

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 21, 2022
@Luap99
Copy link
Member

Luap99 commented Apr 21, 2022

Oh good, github for some reason always uses the date to check what the latest release is instead of semver. So all latest links are redirected to v3.4.7 currently. This is very bad since we use the latest link in several places.

Even worse there is no way to manually overwrite the latest release in github, according to https://stackoverflow.com/questions/22822586/swap-latest-release-on-github you need to change your commit date on the tag which sounds like a bad idea to me.

@mheon @containers/podman-maintainers PTAL

@Luap99 Luap99 added the documentation Issue or fix is in project documentation label Apr 21, 2022
@mheon
Copy link
Member

mheon commented Apr 21, 2022

Well damn.

We can't actually alter tags once they're created because they are signed. Our only potential option would be to tag a new release from the latest release branch?

@Luap99
Copy link
Member

Luap99 commented Apr 21, 2022

I don't think this is the solution. It will happen again every time we have to do a release from an old branch.
I wonder if it would make more sense to hardcode the links to the actual latest version and have a script which can update it for each new release with some form of CI check to ensure it is up to date.

@mheon
Copy link
Member

mheon commented Apr 21, 2022

I'm fine with that, as it shifts the solution away from me and to other folks 😄

Given this - should we move the issue to the podman.io repo?

@Luap99
Copy link
Member

Luap99 commented Apr 21, 2022

No this also applies to podman, for example the link in our Readme also points to latest

@mheon
Copy link
Member

mheon commented Apr 21, 2022

Naturally, because nothing can ever be simple.

That can probably be done manually as part of the release process. Podman.io seems scriptable, though.

@Luap99
Copy link
Member

Luap99 commented Apr 21, 2022

Manually == it will be forgotten, as least that is my experience.

@mheon
Copy link
Member

mheon commented Apr 21, 2022

Fair. I wonder if we could GH actions this - on new tag, check semantic version versus readme latest, update if newer?

@Luap99
Copy link
Member

Luap99 commented Apr 22, 2022

git ls-remote --tags --refs --sort="v:refname" https://github.com/containers/podman.git | sed 's/.*\///' | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | tail -n1
This command should be able to get the latest version from anywhere.

Luap99 added a commit to Luap99/podman.io_old that referenced this issue Apr 22, 2022
We should not use teh latest link for github releases. It will will
always use the latest tag based on the date not semver. So this will
point to v3.4.7 at the moment.

Because such things can happen again we should manually set the version
and update it for each release. Ideally we have some form of automation
for this.

see containers/podman#13947

Signed-off-by: Paul Holzinger <[email protected]>
Luap99 added a commit to Luap99/podman.io_old that referenced this issue Apr 22, 2022
We should not use the latest link for github releases. It will will
always use the latest tag based on the date not semver. So this will
point to v3.4.7 at the moment.

Because such things can happen again we should manually set the version
and update it for each release. Ideally we have some form of automation
for this.

see containers/podman#13947

Signed-off-by: Paul Holzinger <[email protected]>
rhatdan pushed a commit to containers/podman.io_old that referenced this issue Apr 22, 2022
We should not use the latest link for github releases. It will will
always use the latest tag based on the date not semver. So this will
point to v3.4.7 at the moment.

Because such things can happen again we should manually set the version
and update it for each release. Ideally we have some form of automation
for this.

see containers/podman#13947

Signed-off-by: Paul Holzinger <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Apr 23, 2022

The link is now fixed. We can carry on the conversation here on how to make this human proof.

@rhatdan rhatdan closed this as completed Apr 23, 2022
@edsantiago
Copy link
Member

Hi! This has been on my backburner for months. I have a script intended to take care of this, and as of a few minutes ago I confirmed that it handles the v4.3.0 -> .1 transition. However: there is no "msi" for v4.3.0. How do msi files get created? Is that a manual process? Will there be one for v4.3.1? My script fails if it doesn't find the corresponding msi file.

@ashley-cui
Copy link
Member

I think at the moment we've stopped providing msi's and have now moved to an .exe based installer

@ashley-cui
Copy link
Member

I think we're still building MSI's though in our CI so I can upload the MSI regardless, that shouldn't be an issue if we want to continue providing MSI's

@edsantiago
Copy link
Member

Oh I don't care! I've never used Windows and am unlikely ever to. I just want our documentation and links to be accurate.

@Luap99
Copy link
Member

Luap99 commented Nov 10, 2022

The windows install section on podman.io no longer directly links to the binaries, just to the tutorial which links to the the github release page so this is not really a problem any more.

@edsantiago
Copy link
Member

Uh, well, except that the tutorials say:

The Windows installer file is named podman-v.#.#.#.msi, where the # symbols represent the version number of Podman

And one of them also says:

At the time of this writing, the file name is podman-v3.4.4.msi <---- just dead text, not a hyperlink

I find that offensive.

It's very easy (in fact, it's done except for review and merge) to automate this, add a link of the form:

As of YYYY-MM-DD the latest version is [vX.Y.Z](https://link/to/that/exe-or-msi-or-whatever)

So: (1) should I fix the tutorials to say "exe" instead of "msi"? And (2) should I continue with this work?

@mheon
Copy link
Member

mheon commented Nov 10, 2022

RE 1, definitely - the MSI is now legacy.

RE 2, IMO we could just as easily point to the Github releases page and say grab the link from the latest release... But that's also not perfect (releases are chronological, so if we were to do a 3.4.8 right now it would show as latest until we cut 4.3.2), so I won't object to doing this the right way.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Issue or fix is in project documentation kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

6 participants