[CI:BUILD] Cirrus: Never skip running Windows Cross task #16401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
edsantiago
approved these changes
Nov 3, 2022
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
cevich
force-pushed
the
fix_windows_cross
branch
from
33c5df9 to
aa3dae4
Compare
|
Force-pushed: Applied Ed's suggestion. CI will run fast on this PR. |
I thought it was super urgent, but I guess not? In any case, probably best not to add ugly. |
All the other Windows tasks depend on access to a podman-remote build from the Alt. Arch. `Windows Cross` task. Re-arrange the test-skipping call to never skip here only. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
fix_windows_cross
branch
from
aa3dae4 to
f3195c9
Compare
|
/lgtm Thank you |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other Windows tasks depend on access to a podman-remote build from the Alt. Arch.
Windows Crosstask. Re-arrange the test-skipping call to never skip here only.Ref: #16399 (comment)
Does this PR introduce a user-facing change?