Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: do not use apk in builds #16399

Merged
merged 1 commit into from
Nov 4, 2022
Merged

test/e2e: do not use apk in builds #16399

merged 1 commit into from
Nov 4, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 3, 2022

As far as I can tell there is no reason to use apk in these tests. They just build an image and check for it and never use the installed binary. Network calls are always unstable and therefore should be avoided when possible, this ensures no/less flakes.

Fixes #16391

Does this PR introduce a user-facing change?

None

@Luap99
test/e2e: do not use apk in builds
4174901 
As far as I can tell there is no reason to use apk in these tests. They
just build an image and check for it and never use the installed binary.
Network calls are always unstable and therefore should be avoided when
possible, this ensures no/less flakes.

Fixes containers#16391

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2022
vrothberg
vrothberg reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice catch!

@mheon
Copy link
Member

mheon commented Nov 3, 2022

LGTM

@Luap99
Copy link
Member Author

Luap99 commented Nov 3, 2022

windows smoke test looks broken, was already rerun once: https://cirrus-ci.com/task/6678299677032448
@cevich @n1hility PTAL

@cevich
Copy link
Member

cevich commented Nov 3, 2022

Expand-Archive : The path 'podman-remote-release-windows_amd64.zip' either does not exist or is not a valid file system path.

This smells like a task-dependency problem to me, but the YAML looks correct 😕 Did the Windows Cross task fail silently or not attach the binary for some reason...

@cevich
Copy link
Member

cevich commented Nov 3, 2022

...ya, looks like the Windows Cross task is failing silently. That's definitely not good 😖 Ahh, I re-ran it and got something helpful:

/usr/bin/time --verbose --output="$STATS_LOGFILE" $GOSRC/$SCRIPT_BASE/runner.sh
************************************************************
Runner executing altbuild podman-tests as root on fedora-37(fedora-37)
Current environment VM image: fedora-c5178639502278656
************************************************************
SKIPPING: This is a doc- and/or test-only PR with no changes under docs

I know how to fix this...

@cevich cevich mentioned this pull request Nov 3, 2022
Merged
@cevich
Copy link
Member

cevich commented Nov 3, 2022

...okay, that should get this PR sorted once it (or something similar) merges and you rebase this one.

@cevich
Copy link
Member

cevich commented Nov 3, 2022

un-ping @n1hility

@cevich
Copy link
Member

cevich commented Nov 3, 2022

@Luap99 for future reference, if you get completely wedged like this, please feel free to ping me on IRC or matrix. I'm sometimes slow to notice my github mail (and sometimes it gets delivered pretty slowly).

rhatdan
rhatdan reviewed Nov 3, 2022
View reviewed changes
test/e2e/prune_test.go
RUN apk update
RUN apk add bash`, ALPINE)
RUN echo hello > /hello
RUN echo hello2 > /hello2`, ALPINE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a cut and paste error , ALPINE)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK? That's the argument for the FROM %s in the sprintf()?

edsantiago
edsantiago approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Member

I'm OK with someone force-merging this, but since it's (probably) not urgent, I have a preference for rebasing on main (with #16401) so we can confirm that that PR works as it was meant to.

@rhatdan rhatdan merged commit 017521c into containers:main Nov 4, 2022
@Luap99 Luap99 deleted the no-apk branch November 4, 2022 12:02
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@rhatdan rhatdan rhatdan left review comments

@edsantiago edsantiago edsantiago approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New f37 flake: podman image prune: APK error or timeout
6 participants
@Luap99 @mheon @cevich @edsantiago @rhatdan @vrothberg