CI: set and verify DESIRED_NETWORK (netavark, cni) #16389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
edsantiago
force-pushed
the
verify_network_backend
branch
2 times, most recently
from
111f12a to
32aa558
Compare
|
LGTM |
edsantiago
force-pushed
the
verify_network_backend
branch
from
32aa558 to
2bce17c
Compare
|
/hold #15760 appears to be close to merging, I will defer to it and will reconcile conflicts here. |
openshift-ci
bot
added
the
do-not-merge/hold
edsantiago
force-pushed
the
verify_network_backend
branch
from
2bce17c to
6a631b4
Compare
edsantiago
removed
the
do-not-merge/hold
edsantiago
force-pushed
the
verify_network_backend
branch
4 times, most recently
from
5c8c5b3 to
27f5d2b
Compare
edsantiago
force-pushed
the
verify_network_backend
branch
from
27f5d2b to
c0fdde5
Compare
Luap99
reviewed
Nov 3, 2022
.cirrus.yml
Outdated
| - env: &priorfedora_envvars | ||
| DISTRO_NV: ${PRIOR_FEDORA_NAME} | ||
| VM_IMAGE_NAME: ${PRIOR_FEDORA_CACHE_IMAGE_NAME} | ||
| CTR_FQIN: ${PRIOR_FEDORA_CONTAINER_FQIN} | ||
| CI_DESIRED_RUNTIME: crun | ||
| CI_DESIRED_NETWORK: netavark |
There was a problem hiding this comment.
I thought prior fedora should use cni?
There was a problem hiding this comment.
Ugh - that's what happens when I code late in the day. Thank you for catching that. Fixed and pushed.
We have CI tests running in netavark mode when CNI is desired. Add a new .cirrus.yml envariable, CI_DESIRED_NETWORK, which we then force-check in e2e and system tests. Simple copy/paste of containers#14912 (the RUNTIME check) with manual s/RUNTIME/NETWORK/ and other minor changes. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
verify_network_backend
branch
from
c0fdde5 to
d7e70c7
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have CI tests running in netavark mode when CNI is desired.
Add a new .cirrus.yml envariable, CI_DESIRED_NETWORK, which
we then force-check in e2e and system tests. Simple copy/paste
of #14912 (the RUNTIME check) with manual s/RUNTIME/NETWORK/
and other minor changes.
Signed-off-by: Ed Santiago [email protected]