Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXME: Temporary workaround for ubi8 CI breakage #16308

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

edsantiago
Copy link
Member

Emergency import of containers/buildah#4377
required because the ubi8 image changed behind our backs.

On podman main, this commit will be reverted by Ed's
treadmill as soon as a new buildah is vendored into podman.

On side branches, the human doing the vendoring will need to
perform manual surgery. I hope the instructions are good enough.

Signed-off-by: Ed Santiago [email protected]

None

Emergency import of containers/buildah#4377
required because the ubi8 image changed behind our backs.

On podman main, this commit will be reverted by Ed's
treadmill as soon as a new buildah is vendored into podman.

On side branches, the human doing the vendoring will need to
perform manual surgery. I hope the instructions are good enough.

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2022
@edsantiago
Copy link
Member Author

@containers/podman-maintainers PTAL, all in-flight and future PRs are going to need this.

@rhatdan
Copy link
Member

rhatdan commented Oct 26, 2022

LGTM
@containers/podman-maintainers PTAL

@Luap99
Copy link
Member

Luap99 commented Oct 26, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6dd0c83 into containers:main Oct 26, 2022
@edsantiago edsantiago deleted the fix_ubi8_b0rkage branch October 26, 2022 19:34
@edsantiago
Copy link
Member Author

/cherry-pick v4.3

@openshift-cherrypick-robot
Copy link
Collaborator

@edsantiago: only containers org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick v4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

edsantiago added a commit to edsantiago/libpod that referenced this pull request Oct 31, 2022
ubi8 broke our tests. Fix is containers#16308 (don't use images that we
don't control), but it's too hard to backport to this old branch.
Just skip the failing test.

Signed-off-by: Ed Santiago <[email protected]>
edsantiago added a commit to edsantiago/libpod that referenced this pull request Nov 1, 2022
ubi8 broke our tests. Fix is containers#16308 (don't use images that we
don't control), but it's too hard to backport to this old branch.
Just skip the failing test.

Signed-off-by: Ed Santiago <[email protected]>
edsantiago added a commit to edsantiago/libpod that referenced this pull request Nov 2, 2022
ubi8 broke our tests. Fix is containers#16308 (don't use images that we
don't control), but it's too hard to backport to this old branch.
Just skip the failing test.

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants