Define and use a safe, reliable test image #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ubi8 image changed some architecture string yesterday and broke all our CI on all branches, including podman because it too runs bud.bats tests. Solution: use a safe, reliable, trustworthy test image (the one built and used for podman). Because that image does not have the same labels, confirm pull using .Architecture instead. We should stop using ubi8 and registry.redhat (containers#4318). They are unreliable. This PR doesn't fix that; it's just an emergency patch for one specific CI break. We can use this as a basis for future removals of ubi8. Signed-off-by: Ed Santiago <[email protected]>
|
@containers/buildah-maintainers PTAL. This will need to be backported to every live branch. This is not the smallest-possible change, but I believe it's the most futureproof. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Oct 26, 2022
Emergency import of containers/buildah#4377 required because the ubi8 image changed behind our backs. On podman main, this commit will be reverted by Ed's treadmill as soon as a new buildah is vendored into podman. On side branches, the human doing the vendoring will need to perform manual surgery. I hope the instructions are good enough. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Oct 26, 2022
Emergency import of containers/buildah#4377 required because the ubi8 image changed behind our backs. On podman main, this commit will be reverted by Ed's treadmill as soon as a new buildah is vendored into podman. On side branches, the human doing the vendoring will need to perform manual surgery. I hope the instructions are good enough. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Oct 26, 2022
Emergency import of containers/buildah#4377 required because the ubi8 image changed behind our backs. On podman main, this commit will be reverted by Ed's treadmill as soon as a new buildah is vendored into podman. On side branches, the human doing the vendoring will need to perform manual surgery. I hope the instructions are good enough. Signed-off-by: Ed Santiago <[email protected]>
This was referenced Oct 26, 2022
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Nov 7, 2022
Emergency import of containers/buildah#4377 required because the ubi8 image changed behind our backs. On podman main, this commit will be reverted by Ed's treadmill as soon as a new buildah is vendored into podman. On side branches, the human doing the vendoring will need to perform manual surgery. I hope the instructions are good enough. Signed-off-by: Ed Santiago <[email protected]>
flouthoc
added a commit
to flouthoc/buildah
that referenced
this pull request
Nov 19, 2022
Upstream has already stopped using ubi8, this is a backport branch stil using ubi8 so retrofit to use needed arch. Upstream has already stopped using ubi8 after: containers#4377 Signed-off-by: Aditya R <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ubi8 image changed some architecture string yesterday and
broke all our CI on all branches, including podman because
it too runs bud.bats tests.
Solution: use a safe, reliable, trustworthy test image (the
one built and used for podman). Because that image does not
have the same labels, confirm pull using .Architecture
instead.
We should stop using ubi8 and registry.redhat (#4318). They
are unreliable. This PR doesn't fix that; it's just an
emergency patch for one specific CI break. We can use
this as a basis for future removals of ubi8.
Signed-off-by: Ed Santiago [email protected]