Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play kube: notifyproxy: listen before starting the pod #16118

Merged
merged 1 commit into from
Oct 12, 2022
Merged

play kube: notifyproxy: listen before starting the pod #16118

merged 1 commit into from
Oct 12, 2022
+74 −47

Conversation

vrothberg
Copy link
Member

Starting listening for the READY messages on the sdnotify proxies before starting the Pod. Otherwise, we may be missing messages.

[NO NEW TESTS NEEDED] as it's hard to test this very narrow race.

Related to but may not be fixing #16076.

Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

Fix a potential race condition in play kube's sdnotify support.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2022
@vrothberg vrothberg mentioned this pull request Oct 11, 2022
Closed
@vrothberg
Copy link
Member Author

Needs more work. I'll tackle that tomorrow.

@vrothberg
play kube: notifyproxy: listen before starting the pod
7b84a3a 
Starting listening for the READY messages on the sdnotify proxies before
starting the Pod.  Otherwise, we may be missing messages.

[NO NEW TESTS NEEDED] as it's hard to test this very narrow race.

Related to but may not be fixing containers#16076.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Oct 12, 2022

LGTM
@containers/podman-maintainers PTAL

ashley-cui
ashley-cui reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@rhatdan rhatdan merged commit c1d832d into containers:main Oct 12, 2022
@vrothberg vrothberg deleted the proxy-mcproxface branch October 13, 2022 07:07
@edsantiago edsantiago mentioned this pull request Oct 21, 2022
Closed
@lsm5
Copy link
Member

lsm5 commented Oct 21, 2022

@edsantiago guess this needs to be cherrypicked to v4.3? I can add this as a patch to the rpm

@vrothberg
Copy link
Member Author

@edsantiago guess this needs to be cherrypicked to v4.3? I can add this as a patch to the rpm

This is part of v4.3 but apparently not sufficient to fully fix the flake. Can you try restarting the gating tests?

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

Assignees

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrothberg @rhatdan @lsm5 @ashley-cui