Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.2.0-rhel] Add container GID to additional groups #15696

Merged
merged 1 commit into from
Sep 9, 2022
Merged

[v4.2.0-rhel] Add container GID to additional groups #15696

merged 1 commit into from
Sep 9, 2022

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #15618

/assign mheon

NONE

@mheon
Add container GID to additional groups
2154016 
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Signed-off-by: Matthew Heon <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 8, 2022
Merged
@mheon
Copy link
Member

mheon commented Sep 8, 2022

@containers/podman-maintainers PTAL and merge

@flouthoc
Copy link
Collaborator

flouthoc commented Sep 8, 2022

Does this needs a new tag of https://github.com/containers/buildah/tree/release-1.27 ? I can't see how podman build issue is fixed here.

@TomSweeneyRedHat
Copy link
Member

@flouthoc yes, I believe we'll need to spin a never version of Buildah and vendor it in this branch to with the CVE fix in there to address the build portion of this fix.

@flouthoc flouthoc mentioned this pull request Sep 9, 2022
Merged
@flouthoc
Copy link
Collaborator

flouthoc commented Sep 9, 2022

PR here will cut a tag once merged: containers/buildah#4224

@flouthoc
Copy link
Collaborator

flouthoc commented Sep 9, 2022 •
edited
Loading

Tag is here: https://github.com/containers/buildah/releases/tag/v1.27.1

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit c7364c4 into containers:v4.2.0-rhel Sep 9, 2022
@flouthoc
Copy link
Collaborator

flouthoc commented Sep 9, 2022

Merged too early i think this needed buildah vendor as well.

@flouthoc
Copy link
Collaborator

flouthoc commented Sep 9, 2022

Buildah bump PR here: #15715

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @mheon @flouthoc @TomSweeneyRedHat @rhatdan @openshift-merge-robot