Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --sig-proxy flag with podman start --attach #4200

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

mheon
Copy link
Member

@mheon mheon commented Oct 4, 2019

If it's explicitly set, use it, instead of trying to set a sane default.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Oct 4, 2019
@rhatdan
Copy link
Member

rhatdan commented Oct 4, 2019

LGTM

If it's explicitly set, use it, instead of trying to set a sane
default.

Signed-off-by: Matthew Heon <[email protected]>
@mheon mheon force-pushed the fix_sigproxy_start branch from ddc014f to 8b5f165 Compare October 9, 2019 14:12
@baude
Copy link
Member

baude commented Oct 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit f61e399 into containers:master Oct 9, 2019
mheon added a commit to mheon/libpod that referenced this pull request Sep 2, 2022
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Signed-off-by: Matthew Heon <[email protected]>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/podman that referenced this pull request Sep 6, 2022
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Signed-off-by: Matthew Heon <[email protected]>
mheon added a commit to mheon/libpod that referenced this pull request Sep 6, 2022
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Signed-off-by: Matthew Heon <[email protected]>
mheon added a commit to mheon/libpod that referenced this pull request Sep 7, 2022
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Cherry-pick conflicts for v3.0.1-rhel branch have been addressed.

Signed-off-by: Matthew Heon <[email protected]>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/podman that referenced this pull request Sep 8, 2022
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Signed-off-by: Matthew Heon <[email protected]>
dcermak pushed a commit to dcermak/podman that referenced this pull request Sep 22, 2022
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Signed-off-by: Matthew Heon <[email protected]>
(cherry picked from commit d82a416)
mheon added a commit to mheon/libpod that referenced this pull request Feb 3, 2023
Mitigates a potential permissions issue. Mirrors Buildah PR containers#4200
and CRI-O PR containers#6159.

Signed-off-by: Matthew Heon <[email protected]>

MH: Backported to v4.0-rhel per RHBZ #2121541

Signed-off-by: Matthew Heon <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants