Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/docker/go-units from 0.4.0 to 0.5.0 #15593

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2022

Bumps github.com/docker/go-units from 0.4.0 to 0.5.0.

Commits
  • e682442 Merge pull request #40 from kolyshkin/no-regex
  • 7375726 size: stop using regexp
  • cec4960 size_test: add more tests
  • 54c3e55 size_test: add t.Helper annotations
  • 1d23ffa size_test: add parseSize benchmark
  • af07f36 size_test: add tests for 0.3 + suffix
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@vrothberg vrothberg force-pushed the dependabot/go_modules/github.com/docker/go-units-0.5.0 branch 2 times, most recently from 79273be to ae27902 Compare September 6, 2022 11:26
@vrothberg
Copy link
Member

Fixed the test. Mi hasn't been supported.
@containers/podman-maintainers PTAL

@Luap99
Copy link
Member

Luap99 commented Sep 6, 2022

If Mi worked before but now it doesn't would this be a breaking change?

@vrothberg
Copy link
Member

If Mi worked before but now it doesn't would this be a breaking change?

I asked that myself as well but found it to be more of a parser fix than a regression.

@mheon
Copy link
Member

mheon commented Sep 6, 2022

Tests are all still angry. I am inclined to allow this in given that Docker made the same change, but I don't really like it, and if people complain we should consider adding preprocessing to continue to support the old formats if possible.

Bumps [github.com/docker/go-units](https://github.com/docker/go-units) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/docker/go-units/releases)
- [Commits](docker/go-units@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: github.com/docker/go-units
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg force-pushed the dependabot/go_modules/github.com/docker/go-units-0.5.0 branch from ae27902 to eb39d56 Compare September 6, 2022 14:59
@Luap99
Copy link
Member

Luap99 commented Sep 8, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7e2f002 into main Sep 8, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/docker/go-units-0.5.0 branch September 8, 2022 14:54
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants