Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] template: container exists, it shouldn't #16047

Closed
edsantiago opened this issue Oct 4, 2022 · 3 comments
Closed

[email protected] template: container exists, it shouldn't #16047

edsantiago opened this issue Oct 4, 2022 · 3 comments
Labels
flakes Flakes from Continuous Integration kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member 

$ podman container exists f87e402febb6-service
#/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
#| FAIL: exit code is 0; expected 1
#\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Relevant code:

podman/test/system/250-systemd.bats

Lines 436 to 437 in 43a8f1a

systemctl stop $service_name
run_podman 1 container exists $service_container

My understanding of systemd is that systemctl stop shouldn't return until the unit is really truly stopped? Is this a real bug, or a test bug? (It's easy to add a wait to the test, but my gut tells me that's not the right thing to do).
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Oct 4, 2022
@rhatdan rhatdan added the kube label Oct 12, 2022
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

vrothberg added a commit to vrothberg/libpod that referenced this issue Dec 15, 2022
@vrothberg
test/system/250-systemd.bats: fix flake
3ca0e46 
Fix a flake in the kube-template test.  After stopping the service, we
want to make sure that the service container gets removed.  However,
ther is a small race window. `systemctl stop` will return when the
service container _exits_.  In between that and the `container exists`
check, the service container may have not yet been removed.  Hence, add
a loop to account for that race.

Fixes: containers#16047
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg mentioned this issue Dec 15, 2022
Closed
@vrothberg
Copy link
Member

@edsantiago any more flakes on this one? The initial data indicates it's an Ubuntu-only thing. Is that still true?

@edsantiago
Copy link
Member Author

I don't think we've seen this since we stopped testing Ubuntu, so, I'll close.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test/system/250-systemd.bats: fix flake vrothberg/libpod
3 participants
@edsantiago @rhatdan @vrothberg