Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.2] Allow colons in windows file paths #15535

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #15455

/assign baude

Allow the use of colons in file path for `podman save` on Windows.

the `podman save` command was failing on windows due to the use of a
colon between the drive letter and first directory.  the check was
intended for Linux and not windows.

Fixes containers#15247

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Aug 31, 2022

/approve
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@vrothberg
Copy link
Member

Needs to be rebased.

@vrothberg vrothberg closed this Sep 9, 2022
@vrothberg
Copy link
Member

It has been backported in the meantime.

@vrothberg vrothberg reopened this Sep 9, 2022
@vrothberg vrothberg closed this Sep 9, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants