Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colons in windows file paths #15455

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

baude
Copy link
Member

@baude baude commented Aug 24, 2022

the podman save command was failing on windows due to the use of a
colon between the drive letter and first directory. the check was
intended for Linux and not windows.

Fixes #15247

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude [email protected]

Does this PR introduce a user-facing change?

Allow the use of colons in file path for `podman save` on Windows.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Aug 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
the `podman save` command was failing on windows due to the use of a
colon between the drive letter and first directory.  the check was
intended for Linux and not windows.

Fixes containers#15247

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Aug 24, 2022
@mheon
Copy link
Member

mheon commented Aug 24, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 24, 2022

@n1hility PTAL

@rhatdan rhatdan added the windows issue/bug on Windows label Aug 24, 2022
@n1hility
Copy link
Member

Question: Shouldn't colons be allowed for unix based operating systems as well? It looks like this method is only called from import, save and export, and this seems safe. I'm guessing the reason behind the original restriction is usage within a volume spec. Is that right? It seems that's not the case currently, so maybe this is no longer needed?

Otherwise LGTM

@baude
Copy link
Member Author

baude commented Aug 24, 2022

the person who wrote the code left a message saying it was not allowed, but didn't elaborate. given that the person was me and i cannot remember, i probably had a good reason for it but that reason is lost r/n. how about we wait for a bug to show up?

@n1hility
Copy link
Member

sure makes sense to me

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@vrothberg vrothberg merged commit 274a533 into containers:main Aug 25, 2022
@baude
Copy link
Member Author

baude commented Aug 29, 2022

/cherry-pick v4.2

@openshift-cherrypick-robot
Copy link
Collaborator

@baude: new pull request created: #15535

In response to this:

/cherry-pick v4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note windows issue/bug on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] podman machine > podman export error
6 participants