-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow colons in windows file paths #15455
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the `podman save` command was failing on windows due to the use of a colon between the drive letter and first directory. the check was intended for Linux and not windows. Fixes containers#15247 [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
LGTM |
@n1hility PTAL |
Question: Shouldn't colons be allowed for unix based operating systems as well? It looks like this method is only called from import, save and export, and this seems safe. I'm guessing the reason behind the original restriction is usage within a volume spec. Is that right? It seems that's not the case currently, so maybe this is no longer needed? Otherwise LGTM |
the person who wrote the code left a message saying it was not allowed, but didn't elaborate. given that the person was me and i cannot remember, i probably had a good reason for it but that reason is lost r/n. how about we wait for a bug to show up? |
sure makes sense to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherry-pick v4.2 |
@baude: new pull request created: #15535 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
the
podman save
command was failing on windows due to the use of acolon between the drive letter and first directory. the check was
intended for Linux and not windows.
Fixes #15247
[NO NEW TESTS NEEDED]
Signed-off-by: Brent Baude [email protected]
Does this PR introduce a user-facing change?