-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Windows compatibility for machine command #15404
Conversation
0a17ada
to
32f787a
Compare
This doesn't enable Qemu for windows. So, no new functionality added and refactorings should be covered by existent tests, thus no tests provided for now. |
@arixmkii Builds are failing, I added the [NO NEW TESTS NEEDED] flag. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arixmkii, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have some notes that I will paste shortly, and will post some thoughts on #13006 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update to the PR! I have one more follow-up.
Also looks like some lingering compile issues |
2a3d6c3
to
f24f6fc
Compare
Signed-off-by: Arthur Sengileyev <[email protected]>
I believe a single failed test for rootless ubuntu could be just flaky one or a glitch. |
LGTM I'll rerun the flake |
@n1hility do you expect some more work with this one (like me rebasing it, etc)? It says it still is waiting for your approval. |
/lgtm |
Thanks @arixmkii |
Extracting more changes done during experiment in #13006 and continuation of #15372 (split into independent PRs as the first one is already reviewed and they are pretty independent).
It was checked to compile on MacOS and Windows and as it is purely refactoring, no behavior changes are expected.
List of changes
Fixing command line genarated
The only non platform specific change is
This is a correction, because Qemu is using
unix:
(alsotcp:
for TCP) notunix:/
to set the protocol. It was working before, because address is absolute and additional leading/
is harmless).Windows aware runtime directory
On windows the only option is to use either user specific or system wide AppData directories
Extracting unix specific parts from machine.go
Parts, which only can compile on unix are moved to
_unix
version and_windows
alternatives (taking into account some limitations, because of lack of signaling) are provided.Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]