Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Windows compatibility #15372

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

arixmkii
Copy link
Contributor

@arixmkii arixmkii commented Aug 18, 2022

Extracting some work done during experiments implementing #13006

First it replaces hardcoded "/dev/null" with os specific variant provided by Go lang. os.DevNull was used in other places, so, I assume this is just code cleanup change.

Next it changes use of xzcat to xz as default windows build doesn't have xzcat (in a form of application copy or symlink (not supported on that platform).

From the docs https://linux.die.net/man/1/xzcat "xzcat is equivalent to xz --decompress --stdout." So, it should have no functional changes and preserve the bahavior. Used "-d" and "-c" short keys instead of full ones as there was use of "-k" in short form already.
[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

@arixmkii
Copy link
Contributor Author

If your commit really, truly does not need tests, you can proceed
by adding '[NO NEW TESTS NEEDED]' to the body of your commit message.

IMO, it is fine to add this to this PR as the changes are not testable in isolation and should be just covered by regression testing in any form, but will wait for opinions of maintainers.

@mheon
Copy link
Member

mheon commented Aug 18, 2022

I would consider @giuseppe the closest we have to an SME on compression, so I'll ask him to take a look at the xz/xzcat change; remaining changes LGTM. I think we're good to merge without tests, given everything here should already be exercised by the podman machine or E2E tests.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2022

@arixmkii You need to rebase and repush.

@TomSweeneyRedHat
Copy link
Member

LGTM
assuming happy tests

Signed-off-by: Arthur Sengileyev <[email protected]>
@arixmkii
Copy link
Contributor Author

Rebased on latest main.

@mheon
Copy link
Member

mheon commented Aug 23, 2022

One test failure, assuming it's a flake, restarting

/lgtm
/approve
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arixmkii, giuseppe, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Aug 23, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit edde857 into containers:main Aug 23, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
@arixmkii arixmkii deleted the win_compat branch March 1, 2024 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants