[v4.0-rhel] Cirrus: Use fixed netavark/aardvark-dns branch #14326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This won't be significantly impacted by merge-order in relation to containers/aardvark-dns#143 |
|
Oof, I'm at a loss as to why validate fails here, where it passed just fine in the most recent merged PR. |
cevich
changed the title
cevich
force-pushed
the
fix_netavark-aardvark_branch
branch
from
e55a0a2 to
fc591a9
Compare
avoid this warn: ``` golangci/golangci-lint info installed ./bin/golangci-lint golangci/golangci-lint err this script is deprecated, please do not use it anymore. check goreleaser/godownloader#207 ``` Signed-off-by: Pascal Bourdier <[email protected]> Signed-off-by: Chris Evich <[email protected]>
This is important for the stability of CI in case of a future backport that happens to be incompatible with netavark/aardvark `main`. Since CI doesn't run very often on the podman `v4.0` branch, an incompatible change may not be noticed. Fix this by switching off of the `main` branch onto a netavark/aardvark release branches. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
fix_netavark-aardvark_branch
branch
from
fc591a9 to
45d9aad
Compare
Okay, validate should be fixed by backporting update to the installer script that was failing before. |
vrothberg
approved these changes
Jun 2, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for the stability of CI in case of a future backport
that happens to be incompatible with netavark/aardvark
main. Since CIdoesn't run very often on the podman
v4.0branch, an incompatible changemay not be noticed. Fix this by switching off of the
mainbranch ontoa netavark/aardvark release branches.
Does this PR introduce a user-facing change?