Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0-rhel] vendor bumps: c/ocicrypt, c/image and buildah #14196

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 11, 2022

bump c/ocicrypt to v1.1.4
bump c/image to v5.19.3
bump buildah to v1.24.4

This change uses a new ocicrypt which defaults to sha256 hashes and has
already been vendored into c/image and buildah versions listed above.

Signed-off-by: Lokesh Mandvekar [email protected]

@rhatdan @mheon @Luap99 PTAL
/cc @containers/podman-desktop-maintainers

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@mheon
Copy link
Member

mheon commented May 11, 2022

LGTM pending green tests

@lsm5
Copy link
Member Author

lsm5 commented May 11, 2022

Looks like a lot of podman search tests are consistently failing. @TomSweeneyRedHat @mheon @rhatdan if we decide we're ok with simply using v4.1 for rhel 9.0.1 then I can simply close this PR. Let me know..

giuseppe and others added 2 commits May 12, 2022 10:32
the alpine image used previously returns a description that contains
'...':

$ podman search --format json alpine | fgrep ...\"\,
        "Description": "alpine 3.7 with bash, perl, gzip, wget...",

Signed-off-by: Giuseppe Scrivano <[email protected]>
(cherry picked from commit bb8f53a)
Signed-off-by: Lokesh Mandvekar <[email protected]>
bump c/ocicrypt to v1.1.4
bump c/image to v5.19.3
bump buildah to v1.24.4

This change uses a new ocicrypt which defaults to sha256 hashes and has
already been vendored into c/image and buildah versions listed above.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the v4.0-rhel-image-ocicrypt-buildah-bumps branch from a2e9ba1 to 39bf28d Compare May 12, 2022 14:35
@lsm5
Copy link
Member Author

lsm5 commented May 12, 2022

@rhatdan @mheon @Luap99 @TomSweeneyRedHat this should be good to go. PTAL.

@rhatdan
Copy link
Member

rhatdan commented May 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@lsm5 lsm5 changed the title vendor bumps: c/ocicrypt, c/image and buildah [v4.0-rhel] vendor bumps: c/ocicrypt, c/image and buildah May 12, 2022
@lsm5
Copy link
Member Author

lsm5 commented May 12, 2022

is something up with @openshift-ci-robot ? Merges seem to take minutes after an lgtm.

@openshift-ci openshift-ci bot merged commit 2e12f02 into containers:v4.0-rhel May 12, 2022
@lsm5 lsm5 deleted the v4.0-rhel-image-ocicrypt-buildah-bumps branch May 13, 2022 13:43
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants