Make sure tests are cleaned up when they complete #14227
Conversation
Fixes: containers#13789 Signed-off-by: Daniel J Walsh <[email protected]>
openshift-ci
bot
added
the
approved
|
@vrothberg @cdoern PTAL |
| build.WaitWithDefaultTimeout() | ||
| Expect(build).To(Exit(0)) | ||
| err = os.RemoveAll("relative") | ||
| Expect(err).To(BeNil()) |
There was a problem hiding this comment.
shouldn't this be kept, or converted to use relativeDir?
There was a problem hiding this comment.
I think this is ok to rm since he put all of the new files in podmanTest.TempDir
|
Maybe it's end of day review brain, but I'm not sure how this is making sure the tests are cleaned upon completion via these changes? I like the new variable definitions though. |
|
@TomSweeneyRedHat Read the issue that is tied to it. Basically if you create directories or files in TempDir they are removed. @vrothberg found that these files were not being removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes: #13789
Signed-off-by: Daniel J Walsh [email protected]