Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests create files in tree #13789

Closed
vrothberg opened this issue Apr 6, 2022 · 3 comments · Fixed by #14227
Closed

e2e tests create files in tree #13789

vrothberg opened this issue Apr 6, 2022 · 3 comments · Fixed by #14227
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@vrothberg
Copy link
Member

I just noticed that the e2e tests create files in the tree:

test/e2e/default.yaml
test/e2e/hello.tar
test/e2e/relative/

I did not examine it any further but want to leave the breadcrumbs here. Tests should only create temporary files/directories and not alter the local tree.
@cdoern
Copy link
Contributor

cdoern commented Apr 11, 2022

/test/e2e/relative is from me in #12853 and #13531. For that PR putting the relative dir in the tmpdir failed because for some reason build -f... could not find the directory if it was in there. Not sure if I was just doing it wrong, if so I can make a quick patch resolving it.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented May 12, 2022

@cdoern @vrothberg were these cleared up?

rhatdan added a commit to rhatdan/podman that referenced this issue May 12, 2022
@rhatdan
Make sure tests are cleaned up when they complete
b810364 
Fixes: containers#13789

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan mentioned this issue May 12, 2022
Merged
cdoern pushed a commit to cdoern/podman that referenced this issue May 27, 2022
@rhatdan
Make sure tests are cleaned up when they complete
f442fbd 
Fixes: containers#13789

Signed-off-by: Daniel J Walsh <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 14, 2022
@rhatdan @mheon
Make sure tests are cleaned up when they complete
ff72a48 
Fixes: containers#13789

Signed-off-by: Daniel J Walsh <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure tests are cleaned up when they complete rhatdan/podman
3 participants
@rhatdan @vrothberg @cdoern