Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Compat API maximum version to v1.41 #14219

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

mheon
Copy link
Member

@mheon mheon commented May 12, 2022

Docker bumped their API, so we should do the same.

Fixes #14204

Does this PR introduce a user-facing change?

The Compat API now supports the v1.41 API.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@rhatdan
Copy link
Member

rhatdan commented May 12, 2022

LGTM

@Luap99
Copy link
Member

Luap99 commented May 12, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@jwhonce
Copy link
Member

jwhonce commented May 12, 2022

@mheon Did you review changes in the API to see if we need to make changes in the compat handlers?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2022
Docker bumped their API, so we should do the same.

Fixes containers#14204

Signed-off-by: Matthew Heon <[email protected]>
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 23, 2022
@mheon
Copy link
Member Author

mheon commented May 23, 2022

Rebased and repushed. Looks like this was completely forgotten about, but I'm pretty sure we still want it.

@jwhonce
Copy link
Member

jwhonce commented May 23, 2022

@mheon I thought we were waiting on https://issues.redhat.com/browse/RUN-1538 before making this change.

@mheon
Copy link
Member Author

mheon commented May 23, 2022

I thought we were going to merge, and make the changes at a later date?

@mheon
Copy link
Member Author

mheon commented Jun 9, 2022

One more flake, restarting

@vrothberg
Copy link
Member

Friendly ping

@rhatdan
Copy link
Member

rhatdan commented Jul 8, 2022

I think this is time to merge.
/lgtm
/hold
I will leave it to @mheon to cancel the hold.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@mheon
Copy link
Member Author

mheon commented Jul 8, 2022

/hold cancel

Let's go ahead and merge, we can deal with the diffs at a later point

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@openshift-ci openshift-ci bot merged commit 87feb82 into containers:main Jul 8, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
6 participants