-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker client API version negotation resolves 1.40 but creating a container with a certain image platform requires at least 1.41 although Podman does support it #14204
Comments
@jwhonce PTAL |
Should just need to change https://github.com/containers/podman/blob/main/version/version.go#L44 to v1.41 |
Docker bumped their API, so we should do the same. Fixes containers#14204 Signed-off-by: Matthew Heon <[email protected]>
A friendly reminder that this issue had no activity for 30 days. |
@mheon what ended up happening with this? |
I have a PR open. I thought we were clear to merge, but there seems to be disagreement. We can work this out on Monday in a postscrum. |
Any update ? |
Interested in this feature |
We have cards in our backlog to review the changes between 1.40 and 1.41 and implement the differences. It is on the roadmap, but not scheduled yet. |
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind feature
Description
When trying to use the Docker API with Podman (rootless or not doesn't make a difference) to start a container with setting an image platform it returns an error.
Steps to reproduce the issue:
Create a new Go Docker API client with
client.WithAPIVersionNegotiation()
Try to create a new container with specifying the image platform
Describe the results you received:
Docker client returns the following error
Describe the results you expected:
Container should be created taking the image platform into account (if feasible).
Additional information you deem important (e.g. issue happens only occasionally):
The version is coming from version/version.go but if I manually set the version to
1.41
it works but I wouldn't consider this a real option because the code is part of a library and should actually use the proper negotiation procedure - especially if Podman apparently supports the features (and also does respond to the 1.41 endpoint).Output of
podman version
:Output of
podman info --debug
:Package info (e.g. output of
rpm -q podman
orapt list podman
):(Output is from Podman rootless but like already said doesn't matter if rootless or not)
Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)
Yes
Additional environment details (AWS, VirtualBox, physical, etc.):
The text was updated successfully, but these errors were encountered: