-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus: Build multi-arch images + manifests #13478
Conversation
b87cc29
to
17566c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly requests for clarification
Thanks for taking a peek @edsantiago. I'll definitely fix those |
ea603b2
to
86a384f
Compare
Okay, this looks like it's working overall, building images for amd64, arm64, s390x and ppc64le:
Before this merges, I intend to resolving the @TomSweeneyRedHat For now, I'm just intending to replace the github-actions based workflow. But can you confirm those are all the right image FQINs we want? @edsantiago when you have a moment, mind taking a final peek? I intend to add a similar task + cirrus-cron job, to both the Skopeo and Buildah repos. |
force-push: Rebased, did final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was halfway through looking at the logs from the previous run, and they seem fine (although they hurt to read). One question, otherwise LGTM.
I agree, though unfortunately this is somewhat the "nature of the beast", and not all that different from the github-actions output. It's really hard to present parallel stdout/err without resorting to eye-melting colors or heavy buffering then reformatting 😞 |
force-push: had to deal with github-actions YAML conflict (file was updated in another PR) |
Github-actions for large/complex tasks is hard to read and maintain. Reimplement the multi-arch image build workflow into a set of bash scripts that use all native contrainer-org tooling. This requires a special VM image setup with emulation to build foreign architectures. It also requires renaming the `helloimage` directory, because the build script uses the directory name in the image FQIN. Signed-off-by: Chris Evich <[email protected]>
force-push: Since I got to re-run all the tests anyway, might as well remove the unnecessary |
There won't be logs to review this time, but LGTM based on earlier logs and on |
Thanks @edsantiago |
LGTM |
/hold cancel |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Github-actions for large/complex tasks is hard to read and maintain.
Reimplement the multi-arch image build workflow into a set of bash
scripts that use all native contrainer-org tooling. This requires
a special VM image setup with emulation to build foreign architectures.
It also requires renaming the
helloimage
directory, because the buildscript uses the directory name in the image FQIN.