Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Build multi-arch images + manifests #13478

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

cevich
Copy link
Member

@cevich cevich commented Mar 10, 2022

Github-actions for large/complex tasks is hard to read and maintain.
Reimplement the multi-arch image build workflow into a set of bash
scripts that use all native contrainer-org tooling. This requires
a special VM image setup with emulation to build foreign architectures.
It also requires renaming the helloimage directory, because the build
script uses the directory name in the image FQIN.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@cevich cevich force-pushed the build_push branch 3 times, most recently from b87cc29 to 17566c4 Compare March 10, 2022 19:11
@cevich cevich requested a review from edsantiago March 10, 2022 20:41
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly requests for clarification

.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Show resolved Hide resolved
.cirrus.yml Show resolved Hide resolved
@cevich
Copy link
Member Author

cevich commented Mar 23, 2022

Thanks for taking a peek @edsantiago. I'll definitely fix those FIXMEs and *standardvm thing. Until containers/automation_images#97 is ready, this can stay a 'draft' / POC.

@cevich cevich force-pushed the build_push branch 4 times, most recently from ea603b2 to 86a384f Compare March 24, 2022 20:56
@cevich
Copy link
Member Author

cevich commented Mar 25, 2022

Okay, this looks like it's working overall, building images for amd64, arm64, s390x and ppc64le:

Before this merges, I intend to resolving the .cirrus.yml fixme to use only_if: $CIRRUS_CRON == 'multiarch' on the task. I'll then add a new Cirrus-cron job called "multiarch" set to run daily or weekly or whatever. So no PR will ever see this task run, but we'll pick up any failures by the daily notification e-mails.

@TomSweeneyRedHat For now, I'm just intending to replace the github-actions based workflow. But can you confirm those are all the right image FQINs we want?

@edsantiago when you have a moment, mind taking a final peek? I intend to add a similar task + cirrus-cron job, to both the Skopeo and Buildah repos.

@cevich cevich requested a review from TomSweeneyRedHat March 25, 2022 19:13
@cevich cevich marked this pull request as ready for review March 25, 2022 19:13
@cevich cevich changed the title [WIP] [CI:BUILD] Cirrus: Build multi-arch images + manifests [WIP] Cirrus: Build multi-arch images + manifests Mar 25, 2022
.cirrus.yml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2022
@cevich cevich changed the title [WIP] Cirrus: Build multi-arch images + manifests Cirrus: Build multi-arch images + manifests Mar 28, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@cevich
Copy link
Member Author

cevich commented Mar 28, 2022

force-push: Rebased, did final FIXME replacements, added push credentials, and removed github-action workflow.

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was halfway through looking at the logs from the previous run, and they seem fine (although they hurt to read). One question, otherwise LGTM.

.cirrus.yml Outdated Show resolved Hide resolved
@cevich
Copy link
Member Author

cevich commented Mar 28, 2022

although they hurt to read

I agree, though unfortunately this is somewhat the "nature of the beast", and not all that different from the github-actions output. It's really hard to present parallel stdout/err without resorting to eye-melting colors or heavy buffering then reformatting 😞

@cevich
Copy link
Member Author

cevich commented Mar 28, 2022

force-push: had to deal with github-actions YAML conflict (file was updated in another PR)

Github-actions for large/complex tasks is hard to read and maintain.
Reimplement the multi-arch image build workflow into a set of bash
scripts that use all native contrainer-org tooling.  This requires
a special VM image setup with emulation to build foreign architectures.
It also requires renaming the `helloimage` directory, because the build
script uses the directory name in the image FQIN.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member Author

cevich commented Mar 28, 2022

force-push: Since I got to re-run all the tests anyway, might as well remove the unnecessary skip Ed noticed.

@edsantiago
Copy link
Member

There won't be logs to review this time, but LGTM based on earlier logs and on git range-diff

@edsantiago
Copy link
Member

/lgtm
/hold

New task is in black, at 8 o'clock:
cirrus-map-pr13478

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@cevich
Copy link
Member Author

cevich commented Mar 29, 2022

Thanks @edsantiago

@TomSweeneyRedHat
Copy link
Member

LGTM
and thanks @cevich!

@TomSweeneyRedHat
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2022
@TomSweeneyRedHat
Copy link
Member

/approved
/lgtm

@edsantiago edsantiago added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: cevich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d0d805b into containers:main Mar 30, 2022
@cevich cevich deleted the build_push branch April 18, 2023 14:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants