Build push #97
Build push #97
Conversation
cevich
force-pushed
the
build_push
branch
3 times, most recently
from
07e1f68 to
87bd0ba
Compare
cevich
force-pushed
the
build_push
branch
2 times, most recently
from
d313a02 to
b36c528
Compare
|
Cirrus CI build successful. Image ID |
cevich
force-pushed
the
build_push
branch
3 times, most recently
from
79348ea to
09e0dbd
Compare
|
Cirrus CI build successful. Image ID |
cevich
force-pushed
the
build_push
branch
6 times, most recently
from
437a769 to
13d9b49
Compare
|
Cirrus CI build successful. Image ID |
cevich
force-pushed
the
build_push
branch
4 times, most recently
from
cc252ee to
3806c13
Compare
|
Cirrus CI build successful. Image ID |
|
Cirrus CI build successful. Image ID |
1 similar comment
|
Cirrus CI build successful. Image ID |
cevich
force-pushed
the
build_push
branch
2 times, most recently
from
607928e to
d2d99a4
Compare
cevich
force-pushed
the
build_push
branch
2 times, most recently
from
53802ef to
b7b5ab1
Compare
|
Thanks, yeah no rush, it's aimed at replacing something already "working", so low-urgency. I believe you already saw/reviewed the underlying Edit: intended use ref: containers/podman#13478 |
|
Sorry for the delay - every time I start on this, other priorities come up. And... sorry again, but I can't really review this. It's huge, and there's a lot of outside context I'm not privy to. I've done one full pass looking for basic inconsistencies, but I really can't review this in depth. I'd say just go for it, push it, and if something breaks it can be iteratively fixed. |
Yep I understand. Most of the outside context you've reviewed in the past, but it is complex overall. However, my goal here is to re-implement the (3x duplicated) github-action workflow in a way that's unit & integration tested, can be re-used across all three repos., and is mostly human readable/maintainable (given some amount of "study-time" of course). Though I totally understand reviewing this likely also requires at least some understanding of the github-action workflow...which is a built-up mess, tweaked and extended based on lots of group discussions 😖 Perhaps it would be helpful to future maintainers, if instead of one big Some Context: These images are ultimately downloaded thousands of times per month, so if some change is needed in the build process, I want this overall build setup to be maintainable by people other than me. Maybe that's asking too much though, I can't tell. If you have readability suggestions, I'm definitely all ears 👂 |
|
Converting this back to draft-status so the |
cevich
force-pushed
the
build_push
branch
2 times, most recently
from
dd04d65 to
2e5e9c2
Compare
|
Cirrus CI build successful. Image ID |
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
|
Force-push: removed temporary |
|
Cirrus CI build successful. Image ID |
|
LGTM but the github diff page is showing a bunch of ugly dark yellow warning messages |
Ya, ignore those, they're false-positive YAML problems. Anyway, thanks for looking, I'll fix up the docs and get this in. |
|
Cirrus CI build successful. Image ID |
These changes produce a new special-purpose VM image containing an embedded script (
main.sh) designed to make use of the (included)build-push.shscript from c/automation. The intent is for the skopeo, buildah, and podman repositories to have a shared, uniform, and standard way for building then pushing their own multi-arch manifest lists for public consumption. To that end, a system-test is included here to confirm expected output, given mock inputs.Note: Currently this task is performed using a difficult to read/maintain Github-actions workflow, making use of docker and buildx. Worse, due to design/implementation defects, this workflow is duplicated across all three containers-org repositories.