Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman machine rm removes the mounted socket file on macOS #13442

Conversation

tricktron
Copy link
Contributor

Fixes #13301.

…on macos")

[NO NEW TESTS NEEDED]
Signed-off-by: Thibault Gagnaux <[email protected]>
@tricktron tricktron force-pushed the rm-mounted-host-socket-on-macos branch from 28fb1a9 to 01514f3 Compare March 6, 2022 15:25
@rhatdan
Copy link
Member

rhatdan commented Mar 7, 2022

Thanks @tricktron
LGTM
@n1hility @baude @ashley-cui PTAL
@containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Mar 7, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan, tricktron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@n1hility
Copy link
Member

n1hility commented Mar 7, 2022

Lgtm thanks!

@rhatdan
Copy link
Member

rhatdan commented Mar 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@rhatdan rhatdan added the macos MacOS (OSX) related label Mar 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit e1f00b4 into containers:main Mar 7, 2022
@tricktron tricktron deleted the rm-mounted-host-socket-on-macos branch March 7, 2022 13:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. macos MacOS (OSX) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman machine rm should remove the mounted host socket as well on macOS
5 participants