Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman machine rm should remove the mounted host socket as well on macOS #13301

Closed
benoitf opened this issue Feb 21, 2022 · 3 comments · Fixed by #13442
Closed

podman machine rm should remove the mounted host socket as well on macOS #13301

benoitf opened this issue Feb 21, 2022 · 3 comments · Fixed by #13442
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. macos MacOS (OSX) related

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 21, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

With podman 4.0 it's pretty cool that we have podman socket mounted on the macOS host.

I can create machines with init command and then I've socket mounted on
$HOME/.local/share/containers/podman/machine/<machine-name>/podman.sock

But removing the machine should also remove this socket file

Steps to reproduce the issue:

  1. podman machine init --now

  2. Check that there is a file $HOME/.local/share/containers/podman/machine/<machine-name>/podman.sock

  3. podman machine rm

  4. File at $HOME/.local/share/containers/podman/machine/<machine-name>/podman.sock should be removed

Describe the results you received:

local socket is still there

Describe the results you expected:

local socket should be removed

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

4.0.0-dev

(paste your output here)

Output of podman info --debug:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

(paste your output here)

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

Yes/No

Additional environment details (AWS, VirtualBox, physical, etc.):

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 21, 2022
@benoitf benoitf changed the title podman rm should remove the mounted host socket as well on macOS podman machine rm should remove the mounted host socket as well on macOS Feb 21, 2022
@mheon
Copy link
Member

mheon commented Feb 21, 2022

@baude PTAL

@mheon mheon added the macos MacOS (OSX) related label Feb 21, 2022
@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2022

@n1hility PTAL

@n1hility
Copy link
Member

n1hility commented Feb 21, 2022

I agree this should be cleaned up as part of rm. I will send a PR.

tricktron added a commit to tricktron/podman that referenced this issue Mar 6, 2022
…on macos")

[NO NEW TESTS NEEDED]
Signed-off-by: Thibault Gagnaux <[email protected]>
tricktron added a commit to tricktron/podman that referenced this issue Mar 14, 2022
…on macos")

[NO NEW TESTS NEEDED]
Signed-off-by: Thibault Gagnaux <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Mar 30, 2022
…on macos")

[NO NEW TESTS NEEDED]
Signed-off-by: Thibault Gagnaux <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. macos MacOS (OSX) related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants