Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AssertionError: 'alpine' not found in 'docker.io/docker/desktop-kubernetes' #13290

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Fix AssertionError: 'alpine' not found in 'docker.io/docker/desktop-kubernetes' #13290

merged 4 commits into from
Feb 21, 2022

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 18, 2022

Backport of #13239 and #13241

baude and others added 3 commits February 18, 2022 11:51
@baude @cevich
Fix images since/after tests
ce5359f 
For the since and after imagve filter tests, instead of using the
read-only cache of images, we just use the empty r/w store.  We then
build three images that are strictly predictable.

Signed-off-by: Brent Baude <[email protected]>
@baude @cevich
Changes of docker descriptions
2fd1ff9 
It looks like some descriptions have changed on the docker registry
where we had been searching for images that include 'alpine'.  We are
now seeing an image in the initial list that has 'alpine' in its
description.

Signed-off-by: Brent Baude <[email protected]>
@edsantiago @cevich
[CI:DOCS] logformatter: handle python logs
e906e9c 
We've got some python tests running in CI, and they're really hard
to troubleshoot. This PR:

  1) colorizes python unittest lines (ok / skipped / fail), and
  2) links to source files

The color is nice for skimming, but it's the linking that might
make it much easier to diagnose future failures.

(Context: failure today in test/python/docker/compat/test_images.py)

Signed-off-by: Ed Santiago <[email protected]>
@cevich cevich requested review from edsantiago and baude February 18, 2022 17:03
@cevich
Copy link
Member Author

cevich commented Feb 18, 2022

Dang, I thought this would have resolved the problem (log). @baude any idea what I'm missing?

@TomSweeneyRedHat
Copy link
Member

Changes LGTM
test redness does not.

@edsantiago
Copy link
Member 

    AssertionError: 'alpine' not found in 'docker.io/docker/desktop-kubernetes kubernetes binaries for desktop. compiled fr...'

Who is doing the truncation (fr...)? Is that python or podman?

@edsantiago
Copy link
Member

Answered my own question: it's podman:

$ bin/podman image search alpine|grep -v alpine
INDEX       NAME                                           DESCRIPTION                                      STARS       OFFICIAL    AUTOMATED
docker.io   docker.io/docker/desktop-kubernetes            Kubernetes binaries for Desktop. Compiled fr...  12
docker.io   docker.io/puppet/r10k                          r10k on a Docker image. Based on Alpine          4
docker.io   docker.io/armswdev/c-hello-world               Simple hello-world C program on Alpine Linux...  0

(v3.4 truncates the Description. v4.0 does not).

This approach will therefore not work in v3.4. It might work with --no-trunc, but I don't know how to pass that in python-land. @baude any reason not to just remove this test entirely in v3.4?

@mheon
Copy link
Member

mheon commented Feb 21, 2022

I am perfectly fine with skipping this on v3.x, or just making it check that any line of the output contains alpine instead of requiring every line to contain it.

@cevich
Copy link
Member Author

cevich commented Feb 21, 2022

Good eye @edsantiago. @mheon since this test is relying on external inputs we have no control over, and it's a long-term maintenance branch, disabling it is probably the better choice...

@cevich
Disable search-images test
4fa7a2e 
Found images being returned which do have "Alpine" in the description.
However, test fails because podman truncates the field.  Disabling test
since this is a long-term maintenance branch.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member Author

cevich commented Feb 21, 2022

...disabled with a comment explaining why.

edsantiago
edsantiago approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logformatter and py changs lgtm. I'd like @baude's confirmation on the other one.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2022
@baude
Copy link
Member

baude commented Feb 21, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit f1d510b into containers:v3.4 Feb 21, 2022
This was referenced Feb 22, 2022
Merged
Merged
@vrothberg vrothberg mentioned this pull request Apr 19, 2022
Merged
@cevich cevich deleted the v3.4_since_after_tests branch April 18, 2023 14:45
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago approved these changes

@baude baude Awaiting requested review from baude

Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cevich @TomSweeneyRedHat @edsantiago @mheon @baude @openshift-merge-robot