Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore machine start logic that was hanging #12959

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Restore machine start logic that was hanging #12959

merged 1 commit into from
Jan 21, 2022

Conversation

afbjorklund
Copy link
Contributor

After refactoring Stop(), mounting volumes was hanging in Start().

Restore the conditional, and add error reporting from isListening.

Fixes issue from #12835 (comment)

Starting machine "podman-machine-default"
INFO[0000] waiting for clients...                       
Waiting for VM ...
INFO[0000] new connection from @ to /run/user/1000/podman/qemu_podman-machine-default.sock 
Mounting volume... /home/anders/mywork:/tmp/workspace
Machine "podman-machine-default" started successfully

@afbjorklund
Copy link
Contributor Author

/cc @baude

@openshift-ci openshift-ci bot requested a review from baude January 21, 2022 07:21
@afbjorklund
Copy link
Contributor Author

Currently it just dials the ssh, might want to do some kind of handshake (but probably not the whole SSH login)

@afbjorklund afbjorklund mentioned this pull request Jan 21, 2022
Closed
@rhatdan
Copy link
Member

rhatdan commented Jan 21, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@afbjorklund
Restore machine start logic that was hanging
e834297 
After refactoring Stop(), mounting volumes was hanging in Start().

Restore the conditional, and add error reporting from isListening.

[NO NEW TESTS NEEDED]

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund afbjorklund requested a review from rhatdan January 21, 2022 15:44
@afbjorklund
Copy link
Contributor Author

Now it is back to just reversing the boolean, so that it doesn't sleep if the machine is running.

@mheon
Copy link
Member

mheon commented Jan 21, 2022

These changes LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 21, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit 94703f6 into containers:main Jan 21, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude Awaiting requested review from baude

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @rhatdan @mheon @openshift-merge-robot