Wait for podman stop to complete

[baude]

if users run podman machine stop && podman machine ls, the status of the
machine in the subsequent ls command would running. now we wait for
everything to complete for stop so that scripting is more accurate.

Fixes: #12815

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM

[TomSweeneyRedHat]

LGTM

[TomSweeneyRedHat]

/lgtm

[afbjorklund]

This made some changes to the "Start" logic, so that it now hangs forever when the machine is running correctly.

--- a/pkg/machine/qemu/machine.go
+++ b/pkg/machine/qemu/machine.go
@@ -386,8 +386,16 @@ func (v *MachineVM) Start(name string, _ machine.StartOptions) error {
        }
 
        if len(v.Mounts) > 0 {
-               for !v.isRunning() || !v.isListening() {
+               running, err := v.isRunning()
+               if err != nil {
+                       return err
+               }
+               for running || !v.isListening() {
                        time.Sleep(100 * time.Millisecond)
+                       running, err = v.isRunning()
+                       if err != nil {
+                               return err
+                       }
                }
        }
        for _, mount := range v.Mounts {

Before it was sleeping if it was not running, or not listening. Now it sleeps if it is running, or not listening.

Side-effect of refactoring the "is" calls to return errors, I suppose.

Ultimately there should be a timeout to this sleep loop, as well ?

@baude

[rhatdan]

Care to open a PR.

[ssbarnea]

@baude I am afraid that some tests might have being useful for the stop functionality because in 4.1.1 stop does not complete. I had to reopen #12815