legacy events: also set Action="die" #12643
Conversation
Since containers#10168, on the event "died", the Status is set to "die" for compatibility with the Docker API. Docker also sets the field Action to "died", so do the same here. Signed-off-by: Leah Neukirchen <[email protected]>
|
CI is complaining about lack of a regression test; otherwise LGTM /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leahneukirchen, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I would love to add a test, but I couldn't find any for this part of the code yet? |
|
LGTM |
|
LGTM |
|
Naw, it's still angry about tests. Integration tests can't test this because it's specific to the HTTP API - APIv2 tests at https://github.com/containers/podman/tree/main/test/apiv2 would seem the appropriate place, but I can find no tests for the |
For Status = "die", Docker sets the exit code of the container to a field "exitCode". Podman uses "containerExitCode". Copy the value into "exitCode" as well, for compatibility. Signed-off-by: Leah Neukirchen <[email protected]>
leahneukirchen
force-pushed
the
events-compat
branch
from
2381b29 to
116a276
Compare
|
These failures are totally unrelated to what I touched, no? |
|
Restarted the failed test |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Closes #12628.
This only affects the legacy Docker API, so can be merged as a bugfix.