Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker incompatibility: events API uses Action="died", not Action="die" #12628

Closed
leahneukirchen opened this issue Dec 16, 2021 · 2 comments · Fixed by #12643
Closed

Docker incompatibility: events API uses Action="died", not Action="die" #12628

leahneukirchen opened this issue Dec 16, 2021 · 2 comments · Fixed by #12643
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@leahneukirchen
Copy link
Contributor

This is essentially the same issue as #10168 (fixed in 3.2.0), but for the Action field of the event. I suggest to change it for the legacy API as well.
@leahneukirchen
Copy link
Contributor Author

also podman sets containerExitCode, but docker sets exitCode.

@rhatdan
Copy link
Member

rhatdan commented Dec 16, 2021

Please open a PR to change. 4.0 is your time to fix these. Although if they are compat then they can be fixed at any time.

@Luap99 Luap99 added the kind/bug Categorizes issue or PR as related to a bug. label Dec 17, 2021
@leahneukirchen leahneukirchen mentioned this issue Dec 17, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

legacy events: also set Action="die" leahneukirchen/podman
3 participants
@leahneukirchen @rhatdan @Luap99