[v3.4] backport: utils: reintroduce moveToCgroup #12540
Conversation
commit ee62711 introduced the regression. It was mistakenly removed as part of a cleanup, but this code is needed by another code path, where we move conmon for the exec session to the same cgroup used by conmon for the process. Closes: containers#12535 [NO NEW TESTS NEEDED] it fixes a regression in the CI Signed-off-by: Giuseppe Scrivano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
If this branch is going to see more activity, we may want to backport #12519 |
|
@containers/podman-maintainers CI is now green after two restarted flakes. PTAL. Even if approved, we still can't cut a new release until #10710 is addressed. |
|
@edsantiago That's going to be problematic because the current read on that is that we need Conmon changes as well - and not exactly small ones. |
|
/lgtm |
|
@mheon for purposes of this release, "skip the stty test" is a perfectly valid resolution. We just can't ship as-is, because the stty bug is no longer a flake, it's failing way too often and will never pass gating. |
|
Disabling this test for the v3.4 (and, if required, v3.4-2-rhel) branches SGTM. I do not see us creating a fix for this that also backports cleanly. |
github-actions
bot
added
the
locked - please file new issue/PR
commit ee62711 introduced the
regression.
It was mistakenly removed as part of a cleanup, but this code is
needed by another code path, where we move conmon for the exec session
to the same cgroup used by conmon for the process.
Closes: #12535
[NO NEW TESTS NEEDED] it fixes a regression in the CI
Signed-off-by: Giuseppe Scrivano [email protected]