-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix remote run/start flake #12519
fix remote run/start flake #12519
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@edsantiago PTAL I don't want to close issue #9597 with this PR since the underlying root cause remains unclear. The good news is that the issue is easy to reproduce on my workstation with:
|
Fix the flake reported in containers#9597 with a workaround to at least stop wasting energy until the root cause has been found and fixed. It seems that a remote run returns before the container has transitioned into the `exited` state which ultimately breaks a subsequent remote start with attach. Signed-off-by: Valentin Rothberg <[email protected]>
@containers/podman-maintainers PTAL |
LGTM |
Tests are green (flake was the usual |
merge me |
/lgtm |
Fix the flake reported in #9597 with a workaround to at least stop
wasting energy until the root cause has been found and fixed.
It seems that a remote run returns before the container has transitioned
into the
exited
state which ultimately breaks a subsequent remotestart with attach.
Signed-off-by: Valentin Rothberg [email protected]