Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remote run/start flake #12519

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

vrothberg
Copy link
Member

Fix the flake reported in #9597 with a workaround to at least stop
wasting energy until the root cause has been found and fixed.

It seems that a remote run returns before the container has transitioned
into the exited state which ultimately breaks a subsequent remote
start with attach.

Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@vrothberg
Copy link
Member Author

@edsantiago PTAL

I don't want to close issue #9597 with this PR since the underlying root cause remains unclear. The good news is that the issue is easy to reproduce on my workstation with:

./bin/podman-remote run --replace --name test alpine sh -c 'start=0; if test -s log; then start=tail -n 1 log; fi; seq expr $start + 1 expr $start + 10 | tee -a log'; ./bin/podman-remote start -a test

Fix the flake reported in containers#9597 with a workaround to at least stop
wasting energy until the root cause has been found and fixed.

It seems that a remote run returns before the container has transitioned
into the `exited` state which ultimately breaks a subsequent remote
start with attach.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

@umohnani8
Copy link
Member

LGTM

@edsantiago
Copy link
Member

Tests are green (flake was the usual search one)

@vrothberg
Copy link
Member Author

merge me

@edsantiago
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6663d72 into containers:main Dec 6, 2021
@vrothberg vrothberg deleted the fix-9597 branch December 7, 2021 07:30
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants