Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor podman pods to report.Formatter #12490

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Dec 2, 2021

[NO NEW TESTS NEEDED]

Support better compatibility output for podman system commands

See #10974
Depends on containers/common#831

Signed-off-by: Jhon Honce [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@jwhonce jwhonce requested review from rhatdan and ashley-cui December 2, 2021 21:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@TomSweeneyRedHat
Copy link
Member

LGTM
once tests are happy. It seems to be complaining about a DCO, but this looks signed? I've restarted.

@jwhonce jwhonce force-pushed the issues/10974-3 branch 2 times, most recently from 85e3c1a to b9ab4fa Compare December 6, 2021 15:47
@jwhonce jwhonce self-assigned this Dec 6, 2021
@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Dec 6, 2021
@mheon
Copy link
Member

mheon commented Dec 6, 2021

LGTM once tests go green

[NO NEW TESTS NEEDED]

Support better compatibility output for podman pods commands

See containers#10974
Depends on containers/common#831

Signed-off-by: Jhon Honce <[email protected]>
@baude
Copy link
Member

baude commented Dec 6, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 7d290b3 into containers:main Dec 6, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants