Refactor report package to be more compatible #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a sibling PR against Podman with these changes? Just to make sure we don't regress in some corner case. |
|
Yes I think it would be best to have a Podman WIP with this PR included. |
* Add additional replacer for ('\', 'n') -> "\n"
* New type Formatter embeds Template and writer/tabwriter handling
* tabwriter.Init() is exposed to allow updating the tabwriter settings
Note: If template origin is OriginPodman or has "table" keyword prefix
output will be filtered through tabwriter. Otherwise, output will be
rendered using given writer.
Note: Once all podman commands have been updated a follow on PR will
remove the old report.Template and report.Writer code.
See containers/podman#10974
Signed-off-by: Jhon Honce <[email protected]>
jwhonce
force-pushed
the
issues/10974
branch
from
8a03111 to
cb82b46
Compare
|
@vrothberg @rhatdan Yup, working the corner cases and tests now. This PR is "safe" to merge before changes to podman. I plan on several PR's for podman since it will require a refactor of all cmd/podman/* |
jwhonce
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jwhonce
added a commit
to jwhonce/podman
that referenced
this pull request
Dec 1, 2021
Leverage new report.Formatter allowing better compatibility from podman command output. See containers#10974 See containers#12455 Depends on containers/common#831 Signed-off-by: Jhon Honce <[email protected]>
jwhonce
added a commit
to jwhonce/podman
that referenced
this pull request
Dec 3, 2021
[NO NEW TESTS NEEDED] Support better compatibility output for podman system commands * Format and content of output from podman version changed to be more compatible See containers#10974 Depends on containers/common#831 Signed-off-by: Jhon Honce <[email protected]>
jwhonce
added a commit
to jwhonce/podman
that referenced
this pull request
Dec 6, 2021
[NO NEW TESTS NEEDED] Support better compatibility output for podman pods commands See containers#10974 Depends on containers/common#831 Signed-off-by: Jhon Honce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: If template origin is OriginPodman or has "table" keyword prefix
output will be filtered through tabwriter. Otherwise, output will be
rendered using given writer.
Note: Once all podman commands have been updated a follow on PR will
remove the old report.Template and report.Writer code.
See containers/podman#10974
Signed-off-by: Jhon Honce [email protected]