Support env variables based on ConfigMaps sent in payload #12447
Conversation
Fixes containers#12363 Signed-off-by: Jakub Dzon <[email protected]>
|
LGTM |
| }) | ||
|
|
||
| It("podman play kube uses all env values from both sources", func() { | ||
| SkipIfRemote("--configmaps is not supported for remote") |
There was a problem hiding this comment.
I know this is a backport but why is this skipped for remote, I thought this PR should fix the remote client so it should be tested in CI as remote.
There was a problem hiding this comment.
Because this particular test uses both new ConfigMap-in-payload approach that works in remote setup and old --configmaps parameter that does not.
There was a problem hiding this comment.
Not a blocker: Could we convert --configmap from static file to payload and send it over ? But following change should go in main as well since it was not supported in original PR.
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakub-dzon, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
github-actions
bot
added
the
locked - please file new issue/PR
What this PR does / why we need it:
This PR is a back port of #12371.
This PR adds support for providing
ConfigMapYAML definitions as part ofpodman play kubeinput.ConfigMapprovided this way can be referred to as a source of environments variables for pods.So far it has only been possible to use ConfigMaps defined in files local to podman starting the pods using
--configmapsparameter, which does not work in remote scenarios (even if the HTTP call is made withing the same host).This PR aims at dealing with the same problem as the other attempt in #12243.
How to verify it
Add ConfigMap definition to a YAML multidoc and refer to it in a container defined in a pod in the same file; properties defined in the ConfigMap will be visible in the pod as environment variables.
Which issue(s) this PR fixes:
Fixes #12363