-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support env variables based on ConfigMaps sent in payload #12371
Support env variables based on ConfigMaps sent in payload #12371
Conversation
56fe968
to
4f46c9b
Compare
4f46c9b
to
0918c62
Compare
@umohnani8 PTAL |
Thanks @jakub-dzon But tests are not happy. |
Looks like some env issue:
Rebasing. |
0918c62
to
f3c3f44
Compare
Fixes containers#12363 Signed-off-by: Jakub Dzon <[email protected]>
f3c3f44
to
dd80635
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakub-dzon, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
Thank you! |
/lgtm |
@rhatdan: would you agree to backporting this feature to the 3.x line so we can consume it sooner than v4 would be released? |
Sure open a Back port PR and we can get it merged and into the next bugfix release. |
Thank you! I've created #12447. |
What this PR does / why we need it:
This PR adds support for providing
ConfigMap
YAML definitions as part ofpodman play kube
input.ConfigMap
provided this way can be referred to as a source of environments variables for pods.So far it has only been possible to use ConfigMaps defined in files local to podman starting the pods using
--configmaps
parameter, which does not work in remote scenarios (even if the HTTP call is made withing the same host).This PR aims at dealing with the same problem as the other attempt in #12243.
How to verify it
Add ConfigMap definition to a YAML multidoc and refer to it in a container defined in a pod in the same file; properties defined in the ConfigMap will be visible in the pod as environment variables. See https://github.com/containers/podman/pull/12371/files#diff-cef3dd63f572aaef036dce65d94140edbfa8c350c2fc836e864a6b1ef653db87R2952 or https://github.com/containers/podman/pull/12371/files#diff-cef3dd63f572aaef036dce65d94140edbfa8c350c2fc836e864a6b1ef653db87R3022
Which issue(s) this PR fixes:
Fixes #12363